Coder Social home page Coder Social logo

Comments (8)

vinaygaba avatar vinaygaba commented on July 4, 2024

This sounds like an interesting idea. One that I would like to give the users of this library. So would you like to see more attribute fields like app:IsCardNameEditable,app:IsExpiryDateEditable ....... Or do you have any other suggestions of implementing this?

from creditcardview.

biddster avatar biddster commented on July 4, 2024

That's just perfect, exactly what I'd like to see.

from creditcardview.

vinaygaba avatar vinaygaba commented on July 4, 2024

Great. I think I can do this :)

from creditcardview.

vinaygaba avatar vinaygaba commented on July 4, 2024

@VenomVendor I wanted your opinion about this.
Does it make sense to deprecate the isEditable attribute and replace it with 3 different attributes(isCreditCardEditable,isCard........) to give more granular control or should I keep the isEditable attribute as is and along with that add 3 new attributes?

from creditcardview.

VenomVendor avatar VenomVendor commented on July 4, 2024

@vinaygaba It's good to have both. I was planning to take this, but you should have already started.

from creditcardview.

vinaygaba avatar vinaygaba commented on July 4, 2024

@VenomVendor Yup I started working on this. Was thinking about what the precedence logic should be like.

from creditcardview.

vinaygaba avatar vinaygaba commented on July 4, 2024

@biddster I have added support for more granular control of fields. Will be releasing the new version of the library today and updating the documentation accordingly. Closing the issue :)

from creditcardview.

vinaygaba avatar vinaygaba commented on July 4, 2024

@biddster This feature is implemented as part of v1.0.3 and I want you to try it out. I have not updated the documentation yet as I am trying to include the flip animation feature as part of the 1.0.3 release. But v1.0.3 is available on maven for you to use as of now and you can try it out. There are 3 additional attributes now: isCardNumberEditable,isCardNameEditable and isExpiryDateEditable.

isEditable field is still available but the granular attributes will have precedence over this field for the respective fields. Do try it out and do let me know what u think.

from creditcardview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.