Comments (22)
Hi @biddster, could you please share your code, specifically the list adapter where u are setting up the views for me to troubleshoot the issue. Thanks.
from creditcardview.
I can't share that very easily due to the sensitive nature of the project, I'll knock up a test application that I can push to github for you.
from creditcardview.
@biddster hey sure no problem. I'll set up something locally as well to test it out!
from creditcardview.
Here you go: https://github.com/biddster/CreditCardViewDemo
from creditcardview.
I can confirm, getting the same issue. Using a List Fragment with BaseAdapter and viewholder pattern. It correctly finds it, but none of the set() methods have any affect.
from creditcardview.
Hi @biddster @heyharvs,
i have identified the fix and will be completing it in the next 1 hour. Will be putting it on maven soon after. Sending an update in a bit. Thank you for pointing this out.
from creditcardview.
@biddster @heyharvs
This was released just now as part of v1.0.3. So if you were already using the library (@bidster you were already using v1.0.3), you will have to delete the library(gradle\caches\modules-2\files-2.1\com.vinaygaba\creditcardview\1.0.3) and do the build again to get the latest version.
from creditcardview.
Thanks @vinaygaba, I'll test it. Is there any reason why you didn't bump the version number to 1.0.4? It's much easier for us all to be certain we're testing your fixed code that way.
from creditcardview.
@biddster The reason I released this as part of v1.0.3 was because v1.0.3 was not "officially" released until today. I wanted to add more features as part of this release and hence I had not updated the documentation until today. Hence, I don't think anyone apart from you was using that version till now as even the Readme file showed v1.0.2 only.
from creditcardview.
Understood. I'm having real trouble getting the latest version. I've blown away my entire gradle cache directory and I'm still seeing the old code. I'm wondering if it's stuck in a maven proxy cache somewhere?
from creditcardview.
Not sure @biddster . If you check the files here -https://oss.sonatype.org/content/groups/staging/com/vinaygaba/creditcardview/1.0.3/
you will see that the files have been updated today. Do you see v1.0.3 in your cache directory once it was downloaded again?
from creditcardview.
Yeah - the aar has been cache on the intertubes somewhere I think.
I delete my gradle cache directory and the aar that gets downloaded is 1,271,325 bytes.
Your new version is 1,271,636.
I suspect that it's cached somewhere as it's not designed to update versions you've already uploaded.
from creditcardview.
@biddster Really sorry about that. Did you try the clean --> build cycle? Or could you download the aar and jar files and replace it in the cache? Never tried it but worth a shot. Before you do this, plz take a back up though as it does match the signatures so its possible it might fail.
from creditcardview.
@biddster Do let me know if you are able to fix the cache issue. Henceforth, I will be more careful about the releases. Sorry about this!
from creditcardview.
Oh don't worry - we'll get to the bottom of it. The bigger worry for me is that if it is really permanently cached, other consumers will suffer the same problem as me as it's already too late.
from creditcardview.
I suspect snapshot releases are the way to go in the future:
Then we can use the changing flag on the compile dependency.
from creditcardview.
@biddster I'm going to read more about this and do releases in a more efficient manner. Sorry about the trouble I might have caused you.
from creditcardview.
Ok, it's working nicely via jitpack.io.
Add jitpack to all projects.
allprojects {
repositories {
maven { url "https://jitpack.io" }
}
}
and then in your app gradle file
dependencies {
compile(group: 'com.github.vinaygaba', name: 'CreditCardView', version: '1.0.3')
}
from creditcardview.
Confirming this bug as fixed.
from creditcardview.
@biddster I had actually added a comment about jitpack but deleted it immediately as there are some new features that are still in dev that were commited to the repo. But looks like jitpack is smart enough to pick binaries from the releases. Which is great!
from creditcardview.
Yes, it's working really well.
Many thanks again for the fixes.
from creditcardview.
@biddster Thank you for pointing this out 👍
from creditcardview.
Related Issues (20)
- expiration defaults to standard keyboard HOT 1
- Can't use with RecyclerView HOT 6
- Cvv max length dinamyc by CardType HOT 1
- Card type auto detection not working on "All but last four" number format
- 1.0.3 declared but getting code inconsistent with (older than) release commit HOT 2
- Font problem HOT 3
- Does Not display programmatically HOT 4
- I want to put CVV HOT 1
- Issues with CreditCardView HOT 5
- passing value into card programmatically HOT 10
- Change card programmatically not work in DialogFragment HOT 1
- [BUG] crashes when type is set to 'none' HOT 5
- Use card View instead of RelativeLayout
- Keep aspect ratio HOT 1
- Can't set plain background on Android 4.2 HOT 1
- How to save values
- Add set and get Cvv function HOT 4
- you have a problem with crediCardView.getCardNumber();
- BMO credit card
- Nesecito
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from creditcardview.