Comments (11)
@biddster I really like this idea! Can u give me certain scenarios where this should fire. Should it fire only when all the values are entered ? Or is there something else you are looking at?
from creditcardview.
I'm thinking of the edit scenario. If the user starts changing the expiry date to something invalid, I think I would want to know immediately so that I can disable an update button. What do you think?
from creditcardview.
I'm thinking on the lines of how generic could these invalid conditions be. Or is it something that should be customizable by the users of this library. Putting some thought behind this.
from creditcardview.
I suspect that's something the library users would want to decide. Perhaps we just have a listener like this which fire on every edit?
interface CreditCardListener {
void onCardNumberChanged();
void onCardHolderChanged();
void onExpiryDateChange();
void onCvvChanged();
}
Would that suffice for most folks? I think it would for me.
from creditcardview.
Yes that way we let the developer handle whatever checks/validation/etc they might want to do. This makes sense and could be very useful. Will try to complete this today!
from creditcardview.
I forgot to mention that I believe it's possible to directly reference the fields in the view. So one could actually add their own text changed listeners to the credit card view.
from creditcardview.
Ah! Does it make this issue irrelevant? I mean is it even needed now?
from creditcardview.
Let me report back and I'll see how well it works. If it's workable, I'll close.
from creditcardview.
Great! Thanks!
from creditcardview.
Seems to work fine, perfectly workable. Closing.
from creditcardview.
Awesome!
from creditcardview.
Related Issues (20)
- expiration defaults to standard keyboard HOT 1
- Can't use with RecyclerView HOT 6
- Cvv max length dinamyc by CardType HOT 1
- Card type auto detection not working on "All but last four" number format
- 1.0.3 declared but getting code inconsistent with (older than) release commit HOT 2
- Font problem HOT 3
- Does Not display programmatically HOT 4
- I want to put CVV HOT 1
- Issues with CreditCardView HOT 5
- passing value into card programmatically HOT 10
- Change card programmatically not work in DialogFragment HOT 1
- [BUG] crashes when type is set to 'none' HOT 5
- Use card View instead of RelativeLayout
- Keep aspect ratio HOT 1
- Can't set plain background on Android 4.2 HOT 1
- How to save values
- Add set and get Cvv function HOT 4
- you have a problem with crediCardView.getCardNumber();
- BMO credit card
- Nesecito
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from creditcardview.