Wrong DisplayVersion registry key written in Windows 11 about vim

[chrisbra]

Isn't that a problem with winget then, if it works when manually installing?

[jonathan-b-wiebe]

Manually installing the latest version from the vim-win32-installer site (9.1.0368) will update the registry key to 9.1.0000, which is still incorrect. The registry key should be set to 9.1.0312.

[chrisbra]

I don't think this is true, here on my current system (Win10), it shows the correct version:

[jonathan-b-wiebe]

I have re-installed using the same version you are running (9.1.0136) and it indeed works correctly.
I will uninstall and reinstall with newer versions to determine when this behavour started.
Thanks for your help!

[jonathan-b-wiebe]

I can now confirm that this behaviour started somewhere between version 9.1.0282 and 9.1.0296. I cannot get move exact then this because these are two consecutive released on the vim-win32-installer site and I am not set up to compile vim in order to test the intermediate versions between these.
Installing version 9.1.0282 shows the following in the registry:

Installing version 9.1.0296 shows the following:

Re-installing version 9.1.0282 returns the key to the correct value.

[RestorerZ]

@jonathan-b-wiebe
And can you please install the latest version with “vim-win32-install” and see what you get in your registry?
https://github.com/vim/vim-win32-installer/releases/tag/v9.1.0368

[chrisbra]

Hm, I don't see any potential changes between v9.1.282 and v9.1.296 that could cause this.

[chrisbra]

I guess this one here: vim/vim-win32-installer@672d8c5 ?

[jonathan-b-wiebe]

Installing gvim_9.1.0368_x64.exe results in the following registry key:

[RestorerZ]

I'm afraid it has to do with this pull request #338 and #14471

[RestorerZ]

Installing gvim_9.1.0368_x64.exe results in the following registry key:

Thank you. I'll check it out now.

[RestorerZ]

That's probably it.

vim/src/dosinst.c

Line 1657 in a4c085a

sprintf(version_string, VIM_VERSION_SHORT "." VIM_VERSION_PATCHLEVEL_STR);

It's possible that this should fix it.

diff --git a/src/Make_mvc.mak b/src/Make_mvc.mak
index aec9efaf9..4d03a722b 100644
--- a/src/Make_mvc.mak
+++ b/src/Make_mvc.mak
@@ -1321,6 +1321,10 @@ $(OUTDIR):
 
 CFLAGS_INST = /nologo /O2 -DNDEBUG -DWIN32 -DWINVER=$(WINVER) -D_WIN32_WINNT=$(WINVER) $(CFLAGS_DEPR)
 
+!IFDEF PATCHLEVEL
+CFLAGS_INST=	$(CFLAGS_INST) -DVIM_VERSION_PATCHLEVEL=$(PATCHLEVEL)
+!ENDIF
+
 install.exe: dosinst.c dosinst.h version.h
 	$(CC) $(CFLAGS_INST) dosinst.c kernel32.lib shell32.lib \
 		user32.lib ole32.lib advapi32.lib uuid.lib \

I'll have to check it again.

[RestorerZ]

Yeah, everything seems to be working as it should.