'gvim --remote' erroneously changes the current directory when the 'shellslash' option is enabled about vim

[chrisbra]

That whole build_drop_cmd() function is a big mess wich dynamically concates some VimScript functionality to perform the actual work. It could benefit from re-doing the whole thing perhaps in VimScript, so it is easier to make adjustments.

Anyhow, I think the following patch should fix the problem:

diff --git a/src/clientserver.c b/src/clientserver.c
index 340add315..f1987743b 100644
--- a/src/clientserver.c
+++ b/src/clientserver.c
@@ -608,7 +608,7 @@ build_drop_cmd(

     // Call inputsave() so that a prompt for an encryption key works.
     ga_concat(&ga, (char_u *)
-                      "<CR>:if exists('*inputsave')|call inputsave()|endif|");
+                      "<CR><C-\\><C-N>:if exists('*inputsave')|call inputsave()|endif|");
     if (tabs)
        ga_concat(&ga, (char_u *)"tab ");
     ga_concat(&ga, (char_u *)"drop");
@@ -652,7 +652,13 @@ build_drop_cmd(
     //    endif
     //  endif
     ga_concat(&ga, (char_u *)":if !exists('+acd')||!&acd|if haslocaldir()|");
+#ifdef MSWIN
+    // undo the effect of 'shellslash', / shouldn't be allowed to be in any valid
+    // path on Windows, so replacing '/' by '\\' should be safe.
+    ga_concat(&ga, (char_u *)"cd -|lcd -|elseif getcwd()->tr('/','\') ==# '");
+#else
     ga_concat(&ga, (char_u *)"cd -|lcd -|elseif getcwd() ==# '");
+#endif
     ga_concat(&ga, cdp);
     ga_concat(&ga, (char_u *)"'|cd -|endif|endif<CR>");
     vim_free(cdp);

[Jajauma]

Yes, this fixes the problem. In the patch you need to escape the backslash ("... tr('/','\\') ..."), but still.

On the other hand, it may be more explicit and easier to comprehend to temporarily reset the 'shellslash' setting (if it exists) for the duration of the operation, as is already done with 'wildignore'.

[chrisbra]

On the other hand, it may be more explicit and easier to comprehend to temporarily reset the 'shellslash' setting (if it exists) for the duration of the operation, as is already done with 'wildignore'.

Yeah, but it is already quite complicated and one would need to test that 'shellslash' exists. I think tr() is easier.

Yes, this fixes the problem. In the patch you need to escape the backslash ("... tr('/','\') ..."), but still.

No, I don't think so. It errors out otherwise: :set shellslash|:cd c:\temp|echo getcwd()->tr('/','\\'): E475: invalid argument: /

[Jajauma]

To my understaing the Vim snippet tr('/','\') is fine, it is the C string literal that requires escaping:

    ga_concat(&ga, (char_u *)"cd -|lcd -|elseif getcwd()->tr('/','\\') ==# '");

so you can actually get

cd -|lcd -|elseif getcwd()->tr('/','\') ==# '

sent to the server.