Add CSS Lint support (using Node's `csslint`) about syntastic

[oryband]

I've sent a pull request fixing this issue on #60.

Closing this one.

[oryband]

@scrooloose: Say, did the latest csslint version stop working with the syntax-checker for you?

I updated it via npm.

If so, please reopen the issue or create a new one until we fix it.

[oryband]

Current CSS Lint version 0.5.0 stopped working with this plugin. Requires a fix.

I've tried looking into it, and can't seem to pin down the problem. The reg-ex appears to be fine, and is supposed to catch the error & warning messages.

Could somebody else try it? I must be missing something.

[oryband]

Well, I asked CSS Lint's developers very nicely to add compact output, so it would be easy to parse. They'd already did that, but still - I can't seem to successfully parse the output.

If you execute csslint --format=compact you'll get an easy to parse print-out:

$ csslint --format=compact base.css

base.css: line 97, col 1, Missing vendor-prefixed CSS gradients for Webkit (Safari, Chrome), Internet Explorer 10+, Opera 11.1+.
base.css: line 35, col 3, Negative text-indent doesn't work well with RTL. If you use text-indent for image replacement explicitly set text-direction for that item to ltr.
base.css: line 57, col 1, Don't use IDs in selectors.
base.css: line 61, col 1, Don't use IDs in selectors.

This is my main syntax_checkers/css.vim code:

let makeprg = 'csslint --format=compact '.shellescape(expand('%'))

let errorformat = '%f\:\ line\ %l\,\ col\ %c\,\ %m,%-G%.%#'

The reg-ex looks fine. I must be missing something. Perhaps an encoding issue or some other bizzare idea?

[chrisgeo]

Ah, was going to ask about this. I couldn't figure out why the parser wasn't working.

[oryband]

@chrisgeo: Do you have any idea what's wrong with my regex? Frustrating. You're welcome to test it yourself.

[chrisgeo]

The biggest problem I see is that CSSLint isn't outputting to stdout/err. I can't actually redirect the output in the shell.

master:[07:56:09]:foo: csslint foo.css > tmp.output
master:[07:56:15]:foo: cat tmp.output 
<empty output>

Let me take a closer look into csslint.

[axolx]

subscribing

[chrisgeo]

@oryband: I'll take a look tonight. Nicolas made some changes to css-lint that fixed a few issues with the way node was doing some underlying stuff. I'll let you know, and make a fork of your code to work on a fix if it's needed.

[chrisgeo]

@oryband: Looks like your regex is fine now (or at least the one I'm using) except that it doesn't look like the output is being parsed into a displayable error. On a CSS file I have the output of "loclist" that you can see in this gist:
https://gist.github.com/1236814

[oryband]

@chrisgeo: Hey, thanks for the help :)

I didn't quite understand what you meant in your last message:

Did you fix the regex? If so, please feel free to commit the fix instead of _gist_ing. We'll check to see if it's working and merge it with the master branch.

[chrisgeo]

@oryban: Sorry for the confusion. I didn't actually end up fixing it because I am not familiar with how Syntastic parses the output. Mostly the second file in the gist: https://gist.github.com/1236814#file_dump.py, is the output I'm seeing with running CSSLINT. I assume that means it found matches to notify with and that the regex is working. The part where I'm stuck on is why that's not being put into clist/cerrors for inspection OR being used to highlight lines by Syntastic. Maybe you can help me out on that and I'd love to help patch it?

[chrisgeo]

Looks like someone added what we needed: CSSLint/csslint#152

And sitedyno did a pull request for it. @oryband

[scrooloose]

Hey guys, sorry for not responding to this earlier - I have just moved to a different country (best excuse ever?!).

I have pulled from sitedyno. Please confirm that this fixes the issue :)

[chrisgeo]

No problem. I'm actually having issues with csslint 0.8.0 not working at all.

[chrisgeo]

@scrooloose have you gotten the syntax checker to notify you at all?

[scrooloose]

you guys still having issues with this? it seems to be working fine for me on csslint 0.8.5

[chrisgeo]

It's working for me now.

[scrooloose]

cool, ill close this off then. Just comment here or open another issue if there are any more problems