Comments (7)
A throttle would do the trick. Is this production critical? So I can prioritize.
from vike.
(replaceState() is called upon window.onscroll)
from vike.
not at all a priority, just logging.
from vike.
sorry didn't mean to scare you with the title, your revised version looks much better 😄
from vike.
Thanks for caring 😊
scare you
I'm not easily scared ;-).
your revised version looks much better 😄
😀 I changed it for others 🙂
from vike.
Released in 0.1.0-beta.35
.
The fix uses a 100ms
throttle; there still can be more than 100 history.replaceState()
calls within 30 seconds. (I'm not increasing the throttle above 100ms
for good reasons.)
The worst thing that can happen for Safari users is that vite-plugin-ssr
restores a wrong scroll position, and I expect this to be very seldom.
Right now, vite-plugin-ssr
has other higher prio stuff, so I'm inclined to not spend too much time for a perfect solution for the time being.
from vike.
SvelteKit does scroll restoration without scroll listener; sveltejs/kit#3938.
from vike.
Related Issues (20)
- Issues using Vike with WebView IOS - Capacitor HOT 8
- Use `throw render()` / `throw redirect()` inside React/Vue/Solid components HOT 1
- New Vike Extensions
- Inconsistent Object Property Formatting in `Prerender.js` HOT 1
- I stumbled upon a Vike bug... HOT 11
- I got this error after running npm run build HOT 3
- Allow STORYBOOK as env var HOT 7
- Potential Bug: Upgrade to Vike 0.4.172 Breaks HMR in Dev Mode HOT 7
- Improve environment variables support HOT 2
- Hot reloading of CSS modules HOT 1
- Could not resolve "vike-react/config" [plugin vike-esbuild] HOT 27
- vike bug HOT 2
- Git clone of vike to Mac OS causes case sensitivity error now HOT 1
- Vike bug HOT 3
- Logger assumes string HOT 2
- Code based routing
- Config inheritance bug HOT 2
- Improve Algolia search
- Bug
- Bugs with alias 'vue': 'vue/dist/vue.esm-bundler.js' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vike.