Coder Social home page Coder Social logo

Comments (7)

brillout avatar brillout commented on August 16, 2024

A throttle would do the trick. Is this production critical? So I can prioritize.

from vike.

brillout avatar brillout commented on August 16, 2024

(replaceState() is called upon window.onscroll)

from vike.

chrisvariety avatar chrisvariety commented on August 16, 2024

not at all a priority, just logging.

from vike.

chrisvariety avatar chrisvariety commented on August 16, 2024

sorry didn't mean to scare you with the title, your revised version looks much better 😄

from vike.

brillout avatar brillout commented on August 16, 2024

Thanks for caring 😊

scare you

I'm not easily scared ;-).

your revised version looks much better 😄

😀 I changed it for others 🙂

from vike.

brillout avatar brillout commented on August 16, 2024

Released in 0.1.0-beta.35.

The fix uses a 100ms throttle; there still can be more than 100 history.replaceState() calls within 30 seconds. (I'm not increasing the throttle above 100ms for good reasons.)

The worst thing that can happen for Safari users is that vite-plugin-ssr restores a wrong scroll position, and I expect this to be very seldom.

Right now, vite-plugin-ssr has other higher prio stuff, so I'm inclined to not spend too much time for a perfect solution for the time being.

from vike.

brillout avatar brillout commented on August 16, 2024

SvelteKit does scroll restoration without scroll listener; sveltejs/kit#3938.

from vike.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.