External browser pref not always respected. about vienna-rss

[mstroeck]

Thanks for reporting this issue. I'm not quite sure how the hell that slipped in :-) But we'll fix it ASAP.

[ansani]

hi dak,
on 2600 code I see these lines:

    case NSEnterCharacter:
        case NSCarriageReturnCharacter:
            if ([mainWindow firstResponder] == [foldersTree mainView])
            {
                if (flags & NSAlternateKeyMask)
                    [self viewSourceHomePageInAlternateBrowser:self];
                else
                    [self viewSourceHomePage:self];
                return YES;
            }
            else if ([mainWindow firstResponder] == [mainArticleView mainView])
            {
                if (flags & NSAlternateKeyMask)
                    [self viewArticlePagesInAlternateBrowser:self];
                else
                    [self viewArticlePages:self];
                return YES;
            }
            return NO;

it seems that - using kb shortcut - you need to use ONLY alt/option to switch from internal to external browser. If this is not the correct behaviour I'll fix. I need a feedback from older users :D

[dak180]

As someone who is not very comfortable reading c based code beyond include directives (I am more of a bash person), could you give me a better idea of what is happening there so I might comment more intelligently?

[ansani]

hi dak, sorry for my cryptic comment :P
I meant that if you want to open articles on internal browser (or show source on internal browser) - following the code - you need to press ALT + RETURN.

If this is not the expected behaviour I can fix this.

[dak180]

That being the behavior unconditionally is not expected. Under the general preferences there is an option that says Open links in external browser.
If that option is checked then ALT + RETURN should open things in the internal browser.
If that option is not checked then ALT + RETURN should open things in the external browser.

The problem is that I have that option unchecked and it is not opening stuff in the internal browser by default.

[ansani]

I agree with you!

My only doubt is that are used two different keys (RETURN and ALT + RETURN) to handle different behaviors (RETURN open on external browser and ALT + RETURN open on internal browser whatever is the option selected on general preferences).

But I think should be fixed ans users should use only RETURN.

[ansani]

@mstroeck what do you think for this issue ? We need to leave actual behavior (RETURN for external and ALT + RETURN for internal browser) or Vienna need to observe the behavior user selected on preferences ?

[dak180]

@ansani personally I very much prefer to have RETURN open things in the internal browser largely because I will tend to go through a large number of things opening them as I find ones I will want to come back to and deleting those that I do not need to examine in such depth; being able to do this with the keyboard on a laptop with one hand allows me to do this rapidly and sending me out of the app or requiring two hands to accomplish this task would (and does from present experience) slow me down quite a bit.

[mstroeck]

I feel the user should be able to set what he wants in the preferences.

[TheSpyder]

I didn't see this here :)

I've submitted a pull request (#32) to fix this. The problem wasn't return vs alt+return, it's that in no way shape or form did enter on the item list open the internal browser.

In testing my fix it has restored the correct behaviour in all circumstances, honouring both the external browser preference checkbox and overriding it with alt+return while also retaining the new multi-select support added in 2.6. There's a beta build in my fork's download section.