Coder Social home page Coder Social logo

Comments (4)

rchl avatar rchl commented on September 2, 2024

Also quotes within quotes are handled poorly.

  'conditions': [
    ["test_isolation_outdir==''", {

This is from chromium/src/build/isolate.gypi

from gyp-sublime-text.

dpemmons avatar dpemmons commented on September 2, 2024

Thanks for the report. I threw this together since there wasn't anything else available. Don't have a ton of time to fix bugs myself by I'm happy to accept pull requests! :)

from gyp-sublime-text.

rchl avatar rchl commented on September 2, 2024

I think the first code snippet I've provided is actually invalid. Single backslash is for escaping character in a string while the include/exclude patterns are regexp patterns so these must be passed a literal backslash thus double backslash is required.

I guess gyp might be handling single backslash correctly anyway but it's not really correct from the language point of view.

The second example, with doubly quoted string is a bug though.

from gyp-sublime-text.

dpemmons avatar dpemmons commented on September 2, 2024

Awesome, thanks!

from gyp-sublime-text.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.