Include generated theme JSON in repo? about lucario-vscode-theme

[brianleewow]

Yes, adding the JSON to the assets would work!

The situation is kind of hard to explain, but yes our system pulls extensions from github based on an allowlist.

[victor-gp]

Hi @brianleewow, appreciate the interest! 💜

Would it work if I added the JSON file as an asset to each release going forward?

[victor-gp]

That said, I'm not sure I understand the problem.

If I'm not mistaken, the installed extension shouldn't run scripts. We run them all at build time, to transform the YAML file to JSON. Then we only package that JSON file and some extras (README.md, preview screenshot) for the extension.

Can you install & use any other theme extension? May it be a problem with those extra files, rather than the scripts? Is it that your editor's "firewall" looks into the GitHub repo and detects those scripts?

In any case, I did plan to expose the generated JSON, ideally in Releases. Or any other place if that's not convenient.

Let me know if you do need this and I'll try to get to it asap.

[victor-gp]

There you go. 😄

I'll try to automate this so a release's made for every tag going forward, including that JSON theme file.

[victor-gp]

If you find this project helpful, please give it a GitHub star! ⭐

That way, you'll also get a notification every time we make a release. :D

Lastly, don't hesitate to open an issue if you're unhappy about how we syntax highlight any part of a language, or how we colorize the broader editor. Feedback is super welcome!

[victor-gp]

I've fully automated this.

From v2.3.3, both publishing to the VS Marketplace and making a release on GitHub are automated. The GitHub release includes the JSON version of the theme as an asset.

The automation is triggered by pushing a version tag to GitHub.