Comments (6)
Yes, adding the JSON to the assets would work!
The situation is kind of hard to explain, but yes our system pulls extensions from github based on an allowlist.
from lucario-vscode-theme.
Hi @brianleewow, appreciate the interest! 💜
Would it work if I added the JSON file as an asset to each release going forward?
from lucario-vscode-theme.
That said, I'm not sure I understand the problem.
If I'm not mistaken, the installed extension shouldn't run scripts. We run them all at build time, to transform the YAML file to JSON. Then we only package that JSON file and some extras (README.md
, preview screenshot) for the extension.
Can you install & use any other theme extension? May it be a problem with those extra files, rather than the scripts? Is it that your editor's "firewall" looks into the GitHub repo and detects those scripts?
In any case, I did plan to expose the generated JSON, ideally in Releases. Or any other place if that's not convenient.
Let me know if you do need this and I'll try to get to it asap.
from lucario-vscode-theme.
I'll try to automate this so a release's made for every tag going forward, including that JSON theme file.
from lucario-vscode-theme.
If you find this project helpful, please give it a GitHub star! ⭐
That way, you'll also get a notification every time we make a release. :D
Lastly, don't hesitate to open an issue if you're unhappy about how we syntax highlight any part of a language, or how we colorize the broader editor. Feedback is super welcome!
from lucario-vscode-theme.
I've fully automated this.
From v2.3.3, both publishing to the VS Marketplace and making a release on GitHub are automated. The GitHub release includes the JSON version of the theme as an asset.
The automation is triggered by pushing a version tag to GitHub.
from lucario-vscode-theme.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lucario-vscode-theme.