Crash: NullPointerException in NetworkService.java line 99 about quill

[vickychijwani]

This occurs in the following scenario: when the app is in the background, the entire process may get killed, but activity back stack is maintained. So when the app is re-opened, Application#onCreate() is called again, which re-initializes the NetworkService, which sets mApi (and mAuthToken!) to null, which causes the NPE above.

See http://stackoverflow.com/a/14376919/504611 for more info. To reproduce, follow these steps: http://stackoverflow.com/a/18695974/504611, or: minimize the app and launch a few other apps, then lock the phone, unlock it after a minute and open the app again.

The obvious solution is to recreate mApi correctly on application startup, using the following algorithm:

1. When user logs in, record the fact in a persistent boolean flag
2. In Application#onCreate:
   • Construct and start the NetworkService
   • Now if we have a valid access token and the user was logged in, then recreate mApi using the access token
   • Else if we have the user's credentials and the user was logged in, then fire a LoginStartEvent
   • Else do nothing