ProtocolLib PacketAdapters listening for PacketType.Play.Server.MAP_CHUNK causes exceptions for 1.9 clients about viaversion

[Paulomart]

Is this with e8cc25b?

[gigosaurus]

yes

[Paulomart]

Is this happing with all PacketTypes or just the chunk packet?

[gigosaurus]

PacketType.Play.Server.PLAYER_INFO works fine, so it isn't all of them. I haven't tried any others as those are the only ones I use. I'll test them all right now.

[Paulomart]

Yeah it could be the speacial handling for chunks

[gigosaurus]

MAP_CHUNK is the only one with this issue. All the other packets that should be working appear to be working.

[gigosaurus]

This still happens.
Could this be related to issue #38?
I'm thinking maybe the packets aren't being sent correctly, as when the bungee tries to decode the message and read the varint for the packet number, it throws an exception.

I also checked and all of the bytes for the chunk packets that get written in the transformer are correct and completely match what a spigot 1.9 server sends out, yet ours causes weird chunk issues.

[FormallyMyles]

Nah this isn't related, I believe the issue is the packet gets sent from in front of the ViaVersion transformer meaning it doesn't get transformed.

[Paulomart]

@MylesIsCool whats the state on this?

[FormallyMyles]

@Paulomart Not looked into it as it's most likely going take hours to solve.

[FormallyMyles]

I've just tried it and it seems to work fine? is this too good to be true? is life just a dream?

who knows,

@Paulomart @gigosaurus

[gigosaurus]

Noticed that I still had the code for this commented out, and when I uncommented I was getting issues again. With debug enabled I get the same stack trace as before.

I've tested with both the latest release and the latest dev build.