duplicate albums about googlemusic-xbmc

[foreverguest]

which version are you using?

[gilcoh33]

1.1

[gilcoh33]

Hi,

any news on this issue?
im on exp-1.1.1 still duplicated albums appearence

any dev version can solve it?

10x

[foreverguest]

Hi,

I falied to catch this problem in my library, so I'm not sure what could cause this problem for you.

[gilcoh33]

Do you need some logs?
I retested again the 0.8.0 version and this is Ok in this case.

[foreverguest]

Could you send a print screen showing the problem?

[gilcoh33]

I think I know what the problem is, in previous versions the Album list was distributed with the "Albums" tagging, in this version (1.x) the Album is distributed with "Album artist" tagging so thats why I see duplicated albums instead of the album name itself, can you approve this?

This must be changed, there are many people that listen to albums that contain various of artists, please change the code to be listed as Album, NOT album artist.

thanks

[foreverguest]

Actually I have changed artist -> album artist in some places.
Could you use a view where we can see the albums names?

[gilcoh33]

So I think you should change also album_artist - > album.

See in the picture that the same album is seperated cause he has couple of artist in it.

[foreverguest]

So you are browsing 'My library' - > 'Artists'?

[gilcoh33]

No my friend, I'm browsing Albums.

Anyway I don't think you should use the "album artist" tag at all.

Even the original Google Music web app not using it.

Artist is Artist tagging
Album is Album tagging

[gilcoh33]

Found this on the API code:

if albumArtist:
query = "select * from songs where album = :filter and album_artist = :albumArtist order by disc asc, track asc"
elif filter_type == 'album':

as I thought it looks like the code filter "Albums" as "album_artist".
this should be replaced with "album" since there are some albums with different artists --> 1 album with 10 different artists (like for Top40, or some season collections)

Thanks

[foreverguest]

It is my understanding that the 'album_artist' should be the same for all tracks from a single album.
It is the 'artist' tag that varies for each track.
Usually on albums with several artists the 'album_artist' has something like 'Various Artists'.

[gilcoh33]

I got many official albums and many of them not using the "Various Artists", and if they are it will be the same result when many songs with "Various Artists" will be collected to the same album, and it will be huge.

in version 0.8.x the album was filtered for 'album', as I think it should be:

if filter_type == 'album':
query = "select * from songs where album = ? order by disc asc, track asc"
elif filter_type == 'artist':
query = "select * from songs where artist = ? order by album asc, disc asc, track asc"
else:
query = "select * from songs where genre = ? order by title asc"

[foreverguest]

Although I disagree about the use of the 'album_artist' tag, I agree that we should find a way to prevent the same album from being listed more than once.
The problem is that albums from different artists may have the same name, I thought that distinguishing each album by 'album'+'album_artist' was the best way to prevent any confusion.
Do you have other suggestion to deal with same name albums?

[gilcoh33]

You're doing a wonderful job, and I guess you'll know how to handle it better then me,
I just want to get rid of the duplications.

It just weird that this issue wasn't appear on previous versions.
I hope you'll find a way soon

thanks again.

[gilcoh33]

Hi
Thanks for the update - I want to test it, is it already applied? version 0.8.2?

[rui-castro]

Hi @gilcoh33 ,

It's not applied yet.
If you want to try my version, install my repo (http://kodi.ruicastro.me/repository.ruicastro/repository.ruicastro-1.0.1.zip) and install or update the plugin Google Music.

[gilcoh33]

Oh good.
I'll try it

Thanks man, appreciate it

[gilcoh33]

Hi @rui-castro

Your latest version is 1.2 right?
Is it patched with this fix? cause I still see album as album artist

[rui-castro]

Hi @gilcoh33 ,

My version is '1.0.0_ruicastro_0.8.2'.
Here's a direct link to the plugin http://kodi.ruicastro.me/plugin.audio.googlemusic/plugin.audio.googlemusic-1.0.0_ruicastro_0.8.2.zip.

[gilcoh33]

Thanks a lot @rui-castro !!! looks amazing - you just made my day