Comments (6)
Is it mostly to make the package lighter, or have you encountered any issues with regards to the docker dependency?
If only the first, considering the small size of the docker
-package: https://pypi.org/project/docker/7.0.0/#files, i think it would not justify much effort.
If the latter, it would be easy to make a lightweight option (pip install pyvespa[no-docker]
).
Then we wouldn't need to change anything in CI etc.
from pyvespa.
Suggestion: pip install pyvespa[no-docker]
from pyvespa.
Upon further investigation, I found that the suggestion contradicts the related PEP, and thus is not supported in pyproject.toml
by default.
For projects which are packages, extras are a common solution for defining development dependencies, but even under these circumstances they have downsides:
- Because an extra defines optional additional dependencies, it is not possible to install an extra without installing the current package and its dependencies.
- Because they are user-installable, extras are part of the public interface for packages. Because extras are published, package developers often are concerned about ensuring that their development extras are not confused with user-facing extras.
I could still make it happen, by adding back a setup.py, but it doesn't feel like a good practice.
Given the small size of the docker dependency (259kB), is it worth it? @andreer @jobergum
from pyvespa.
no
from pyvespa.
Checked whether the docker
-package introduced many other dependencies as well, but it does not.
pip show docker
Name: docker
Version: 7.0.0
Summary: A Python library for the Docker Engine API.
Home-page: https://github.com/docker/docker-py
Author:
Author-email:
License: Apache License 2.0
Location: /Users/thomas/.pyenv/versions/3.11.8/envs/pyvespa-build/lib/python3.11/site-packages
Requires: packaging, requests, urllib3
Required-by: pyvespa
Ok to close the issue?
from pyvespa.
👍
from pyvespa.
Related Issues (20)
- pyvespa assumes vespaengine/vespa is pulled HOT 2
- Replace old logos with new in notebooks
- Async data operations does not apply retry strategy
- Improve user feedback on error from container logs
- Generate application packages from existing Vespa applications HOT 5
- Can't feed result of get operation into feed delete/update HOT 1
- Convert notebooks to use new prepend syntax
- Deploy the Vespa application with docker for bge-m3 HOT 1
- Refine retry-strategy (429-errors) for VespaSync
- Make VespaCloud (optionally) create key/cert with `vespacli` HOT 1
- Make it more obvious how to retrieve a reference to `Vespa` without redeploying HOT 1
- deploy_to_prod return value should be Vespa HOT 1
- Prod deployment strategy: Support polling for deployment status HOT 4
- Adding `clusters` to an `ApplicationPackage` makes `auth_clients` disappear from `services.to_text`
- Add support for defining `instance` in `DeploymentConfiguration` for VespaCloud
- Bump requests from 2.26.0 to 2.32.2 HOT 4
- Lock main dependencies in CI
- How does Vespa handle ColBERT type queries? HOT 1
- Expose URL in VespaDocker
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyvespa.