Comments (5)
Just as an FYI, writing an equivalent test in vert.x raw http handling (rather than wrapped by Apex) behaves properly, so the problem lies within Apex somewhere.
from vertx-web.
This looks like a race condition to me. Did a little bit of debugging, and it's clear that with both a small and large file attachment, HttpServerRequestImpl::streamToFileSystem is called. This method pauses the request and then resumes it once the Pump to file has been set up.
For a small file, however, the resume call happens AFTER HttpServerFileUpload::complete() is called, meaning that at the point the latter method is called, the request is still paused. For a larger file, HttpServerFileUpload::complete() is called before the resume call within HttpServerRequestImpl::streamToFileSystem, so in effect a small file upload is identified as complete before the request is resumed. This then falls foul of the "paused" check in HttpServerFileUpload::complete() and the notifyEndHandler() call is not made, meaning that the request does not complete on the server. In short this actually appears to be a vert.x bug rather than an Apex bug.
from vertx-web.
Thanks for looking into this.
I'll take a look probably tomorrow, if you can create a reproducer only using Vert.x (not Apex) even better :)
from vertx-web.
Thanks Tim, I'll try and carve out some time today to create a vert.x only reproducer, can't promise it though as I'm a bit stuck for time till Thurs now (from my point of view there's no urgent need for this to be fixed, so unless you're pressed by others, please feel free to hold off till I've at least attempted a vert.x only reproducer).
from vertx-web.
This should be fixed now (bug in vertx-core). I've also added some more tests.
from vertx-web.
Related Issues (20)
- Integrate WebClient with Service Resolver HOT 2
- WebClient does not use the server Address in RequestOptions
- It does not allow loading templates that are outside of the path. HOT 1
- `WebClient.close()` does not return a `Future` or wait for resources to be released HOT 4
- Possibility to close connection HOT 3
- Can't handle http2 errors in StaticHandler AsyncFile HOT 1
- oauth2 should not redirect (HTTP 302) XHR requests HOT 2
- HttpContext.fail() does not release the connection when invoked in SEND_REQUEST phase
- WebClient: NPE on misformatted Date or Expires header HOT 1
- absoluteURI is null when host header is missing HOT 2
- Issue with POST request hanging indefinitely in Vert.x Web HOT 3
- CSRF validation fails because CSRFHandler updates the session AFTER the session is already flushed HOT 1
- SockJS Event Bus Bridge does not keep web sessions alive for clustered session managers
- When upgrade vertx4, the path cannot support colon, and vertx 3 is ok HOT 1
- Use the new `OAuth2AuthorizationURL` in `OAuth2AuthHandler.extraParams`
- Reduce heavy atomic operations on RoutingContextImplBase HOT 1
- Rx Version of OAuth2AuthHandler Handler fails to add scopes HOT 2
- Vertx web randomly returns 404 error for certain POST requests even though for other similar requests it returns 200 HOT 2
- ChainAuthHandlerImpl#postAuthentication throws NPE HOT 1
- BodyHandler should not be added before the ProxyHandler HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vertx-web.