sync example failing when running quasar with verify-instrumentation about vertx-examples

[jponge]

@mhstnsc If you think that we are missing anything obvious with the behavior of Quasar then we will more than gladly review a pull-request with your investigations and solution.

[mhstnsc]

it is also not running correctly:

Adding a print at the beginning of fiberHandler will give this output:

Got http request:
Waiting
Got http request:
Got reply: wibble

Please check this problem first.

[tsegismont]

@jponge @FroMage any of you has a Windows machine? Or can make sure at least the example works on Linux/MacOS?

[jponge]

No I don't have a Windows machine

…

On Tue, May 29, 2018 at 6:51 PM Thomas Segismont ***@***.***> wrote: Assigned #114 <#114> to @jponge <https://github.com/jponge>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#114 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABlaS4Ti3r5vsLWqZtZIDUXQe34XNlGks5t3XyJgaJpZM4HAm3c> .

[tsegismont]

@jponge can you try the example on MacOS then?

[jponge]

Tested with Quasar 0.7.5 and it works very fine.

I get Quasar errors because the agent cannot instrument some methods like a lambda in io/vertx/core/impl/DeploymentManager$DeploymentImpl but this is perfectly expected (that method uses synchronized).

[mhstnsc]

@jponge Did you actually run the test and check the results? See my second comment. Quasar is quite evil if the instrumentation fails and the application will misbehave

[mhstnsc]

@jponge I asked a simple question and at least you could answer my question not just throwing the dead cat to me. I did my investigation, i don't know whats the fix, i reported a problem, i gave a way to reproduce. A bug should be closed after the result has been checked. You closed this issue however i wanted to make sure you added those print messages and things worked fine otherwise the test was working fine also before however incorrect.

Every time i open a bug in vertx , you guys throw the dead cat back to me. Why do you keep this section open for public to open bugs?

[jponge]

@mhstnsc I am trying to be constructive: I did my checks and for me it works. Now you complain and question if I actually did check anything, so where do we go from here? 🤔

Again, if you have more expertise than we do on this subject then we will happily review any contribution you may have.

[mhstnsc]

IMO there's no need to spend time on quasar. IMO is mostly unusable in its current form in production becuase of the manual annotating. They promised to fix it in subsequent java versions whihc might introduce support in JVM and they lead told me they were talking with Oracle about this. I have no further info so far.