Comments (9)
@tsegismont will check the feasibility of this with respect to Cassandra client that might prevent the upgrade
from vertx-dropwizard-metrics.
@vietj in Vert.x 4, the Cassandra client depends on the Datastax Java Driver 4.9.0 which allows to configure different metrics systems (Dropwizard 4, Micrometer 1.5, Microprofile Metrics).
By default, all Datastax Java Driver metrics are disabled but the Dropwizard module dependency is not optional.
So we could exclude the Dropwizard dependency in the Vert.x Cassandra Client.
Side note: as an exercise, I tried to configure a shared Micrometer registry for Vert.x and the Datastax Java Driver. It worked:
https://gist.github.com/tsegismont/087900c497343bcb154e41d3ec29abb3
from vertx-dropwizard-metrics.
thanks for the heads up
what if somebody wants to use Cassandra specific dropwizard metrics ?
from vertx-dropwizard-metrics.
@vietj then they'd have to:
- re-add the dependency on Dropwizard 4
- maintain a Vert.x Metrics SPI implementation with Dropwizard 4
Actually I'm not sure what's the rationale for this issue. Do you remember why you filed it?
If you look at the Dropwizard dev status table, Dropwizard 5 is marked on-pause.
Besides, both Vert.x Dropwizard and DataStax Java Driver depend on Dropwizard 4.0.x.
So it seems to me all is well :-)
from vertx-dropwizard-metrics.
I think it was filed when Dropwizard 5 was a thing ?
from vertx-dropwizard-metrics.
shall we try upgrade to release/4.2.x branch ?
from vertx-dropwizard-metrics.
The Dropwizard website promotes the version 4.1. Version 4.2 is still marked as "in-development."
If we were to upgrade, version 4.1 sounds like the target to me.
from vertx-dropwizard-metrics.
I asked the Dropwizard team about the 4.2 status. They have a beta3 out already and only a handful of remaining issues and said it should be released soon-ish
from vertx-dropwizard-metrics.
Not closed yet. DZ has been upgrade to 4.2 RC2 for 4.1 first beta.
from vertx-dropwizard-metrics.
Related Issues (20)
- Metrics options should use null monitored lists
- Metrics options will not JSON read or JSON write monitored entities
- Metrics name defined in client options is ignored HOT 1
- NPE when nonstandard HTTP method is used in request and broken connection HOT 5
- Negative value in "vertx.pools.datasource.*.in-use" HOT 5
- Collect response codes per configured server url
- New EB metric to monitor if a consumer cannot cope with messages delivered HOT 3
- Make reservoir configurable HOT 1
- Vert.x (and custom) MBeans are not showing with Docker HOT 1
- JSON options: remove backward compatibility for monitoredServerUris, monitoredClientUris and monitoredClientEndpoints
- Incorrect JSON options test HOT 1
- VertxMetricsImpl.createHttpClientMetrics should use a ConcurrentMap HOT 2
- Nullpointer in EventBusMetricsImpl HOT 4
- Server Uris via command line HOT 3
- Issue Http URI metrics multiple servers HOT 1
- Issue Http URI metrics don't respect query parameters HOT 9
- NPE in EventBusMetricsImpl on delivering message while handler registration is not finished yet HOT 2
- Event bus discarded message count HOT 9
- Discarded messages are still counted as pending HOT 3
- Verticle metrics deployment removal
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vertx-dropwizard-metrics.