Coder Social home page Coder Social logo

Comments (9)

vietj avatar vietj commented on May 23, 2024

@tsegismont will check the feasibility of this with respect to Cassandra client that might prevent the upgrade

from vertx-dropwizard-metrics.

tsegismont avatar tsegismont commented on May 23, 2024

@vietj in Vert.x 4, the Cassandra client depends on the Datastax Java Driver 4.9.0 which allows to configure different metrics systems (Dropwizard 4, Micrometer 1.5, Microprofile Metrics).

By default, all Datastax Java Driver metrics are disabled but the Dropwizard module dependency is not optional.

So we could exclude the Dropwizard dependency in the Vert.x Cassandra Client.

Side note: as an exercise, I tried to configure a shared Micrometer registry for Vert.x and the Datastax Java Driver. It worked:

https://gist.github.com/tsegismont/087900c497343bcb154e41d3ec29abb3

from vertx-dropwizard-metrics.

vietj avatar vietj commented on May 23, 2024

thanks for the heads up

what if somebody wants to use Cassandra specific dropwizard metrics ?

from vertx-dropwizard-metrics.

tsegismont avatar tsegismont commented on May 23, 2024

@vietj then they'd have to:

  • re-add the dependency on Dropwizard 4
  • maintain a Vert.x Metrics SPI implementation with Dropwizard 4

Actually I'm not sure what's the rationale for this issue. Do you remember why you filed it?

If you look at the Dropwizard dev status table, Dropwizard 5 is marked on-pause.
Besides, both Vert.x Dropwizard and DataStax Java Driver depend on Dropwizard 4.0.x.

So it seems to me all is well :-)

from vertx-dropwizard-metrics.

vietj avatar vietj commented on May 23, 2024

I think it was filed when Dropwizard 5 was a thing ?

from vertx-dropwizard-metrics.

vietj avatar vietj commented on May 23, 2024

shall we try upgrade to release/4.2.x branch ?

from vertx-dropwizard-metrics.

tsegismont avatar tsegismont commented on May 23, 2024

The Dropwizard website promotes the version 4.1. Version 4.2 is still marked as "in-development."

If we were to upgrade, version 4.1 sounds like the target to me.

from vertx-dropwizard-metrics.

tsegismont avatar tsegismont commented on May 23, 2024

I asked the Dropwizard team about the 4.2 status. They have a beta3 out already and only a handful of remaining issues and said it should be released soon-ish

from vertx-dropwizard-metrics.

tsegismont avatar tsegismont commented on May 23, 2024

Not closed yet. DZ has been upgrade to 4.2 RC2 for 4.1 first beta.

from vertx-dropwizard-metrics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.