Unhandled Promise Rejection when using node-fetch, Shopify remix app with shopify api v9 deployed to vercel about vercel

[andyvanosdale]

I would imagine you are not the only one experiencing this issue. I suspect Shopify did not test their product throughly (for example, in a Vercel hosted environment). I don’t work for Vercel. I would recommend pushing on the Shopify team to fix their issue.

…

________________________________ From: DUONG DUC ANH ***@***.***> Sent: Thursday, February 8, 2024 8:48:02 AM To: vercel/vercel ***@***.***> Cc: Andy Vanosdale ***@***.***>; Mention ***@***.***> Subject: Re: [vercel/vercel] Unhandled Promise Rejection when using node-fetch, Shopify remix app with shopify api v9 deployed to vercel (Issue #11069) @andyvanosdale<https://github.com/andyvanosdale> It appears that I am not the only person facing this issue! Please take a look at the problem reported in the Shopify Remix team mentioned above. Currently, they are addressing the issue by switching the deploy service to Heroku, but this could potentially prove that problems is in the Vercel environment. Remix team has already responded, stating that they will investigate. However, until then, we have no choice but to change the service or keep running in old version which have many deprecated thing — Reply to this email directly, view it on GitHub<#11069 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAR2TOCBGI2U4WQ7DQLXQXLYSR7LFAVCNFSM6AAAAABCDGMLKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGUZDIMZZGE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[anhdd-kuro]

Solve by this comment

[andyvanosdale]

Does this break locally or only when deployed to Vercel? I would recommend checking locally first, and I suspect that it will break locally. Then you can debug and see why the promise rejection is not being handled when using the updated Shopify module.

[anhdd-kuro]

@andyvanosdale unfortunately , this only break when deployed to Vercel
The error only occur if and try to call api using fetch , the static page have no problem
I will try netify to see is this enviroment problem

[andyvanosdale]

Vercel works well with Node’s fetch. I would dig in deeper. Otherwise, practically all projects deployed to Vercel would be broken. Check that the update doesn’t require a specific Node version and you have that set accordingly for Vercel.

…

________________________________ From: DUONG DUC ANH ***@***.***> Sent: Sunday, January 28, 2024 5:22:28 PM To: vercel/vercel ***@***.***> Cc: Andy Vanosdale ***@***.***>; Mention ***@***.***> Subject: Re: [vercel/vercel] Unhandled Promise Rejection when using node-fetch, Shopify remix app with shopify api v9 deployed to vercel (Issue #11069) @andyvanosdale<https://github.com/andyvanosdale> unfortunately , this only break when deployed to Vercel , I will try netify The error only occur if and try to call api using fetch , the static page have no problem — Reply to this email directly, view it on GitHub<#11069 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAR2TOEPIWJTE5MRL2YDDWTYQ32VJAVCNFSM6AAAAABCDGMLKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTHAYDONRVGQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[anhdd-kuro]

@andyvanosdale
I have created simple reproduction
It's work fine at route /products_2 which directly use fetch , but failed at /products
Maybe this is shopify-app-template-remix 's problem but I can't explain why it's work normally at local
According to the logs , it passed authenticate

[andyvanosdale]

I'm not sure why it may be working locally vs in Vercel. However, I do see that Shopify has called out that the v9 update changed how they use fetch moving forward.

See:

• Migration Notes
• Docs

[anhdd-kuro]

I'm using their latest template and checked the docs, but I did not find any problems.
I said it was working locally, but it is actually hosted on Cloudflare

[andyvanosdale]

The docs and what I posted about are clearly talking about using that template with Node and what you need to do to resolve it.

…

________________________________ From: DUONG DUC ANH ***@***.***> Sent: Tuesday, January 30, 2024 7:06:17 AM To: vercel/vercel ***@***.***> Cc: Andy Vanosdale ***@***.***>; Mention ***@***.***> Subject: Re: [vercel/vercel] Unhandled Promise Rejection when using node-fetch, Shopify remix app with shopify api v9 deployed to vercel (Issue #11069) I'm using their latest template and checked the docs, but I did not find any problems. I said it was working locally, but it is actually hosted on Cloudflare — Reply to this email directly, view it on GitHub<#11069 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAR2TOBUMN56RVZQACLBDYTYRED6TAVCNFSM6AAAAABCDGMLKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXGA4TSNRZGU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[anhdd-kuro]

@andyvanosdale
It appears that I am not the only person facing this issue!
Please take a look at the problem reported in the Shopify Remix team mentioned above.
Currently, they are addressing the issue by switching the deploy service to Heroku, but this could potentially prove that problems is in the Vercel environment.
Remix team has already responded, stating that they will investigate. However, until then, we have no choice but to change the service or keep running in old version which have many deprecated thing

[anhdd-kuro]

My bad ! I thought you are on vercel team

[andyvanosdale]

No worries! I would remember that nothing on Vercel’s side has changed. This was Shopify’s own doing. The Shopify Remix code is open source, so the library could be further debugged by any software developer.

…

________________________________ From: DUONG DUC ANH ***@***.***> Sent: Thursday, February 8, 2024 10:43:06 AM To: vercel/vercel ***@***.***> Cc: Andy Vanosdale ***@***.***>; Mention ***@***.***> Subject: Re: [vercel/vercel] Unhandled Promise Rejection when using node-fetch, Shopify remix app with shopify api v9 deployed to vercel (Issue #11069) My bad ! I thought you are on vercel team — Reply to this email directly, view it on GitHub<#11069 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAR2TOC5F2TJTUL4ZLLUQDLYSSM2VAVCNFSM6AAAAABCDGMLKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZTGY4TONJZGY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[kenju]

@anhdd-kuro

it ran smoothly with Remix version 2.5.1 and Shopify API version 8.1.

Can you share the dependencies from package.json that worked by having shopify-api: 8.1 to see which versions you used for other peer dependencies

The error basically says that the parameters passed does not support Streams API. This is achieved by this polyfill, which vercel/vercel installs here.

The usage of Streams hinges on making responses available as streams. For example, the response body returned by a successful fetch request is a ReadableStream that can be read by a reader created with ReadableStream.getReader().

[anhdd-kuro]

@kenju
here's dependencies that working with shopify-api: 8.1

"dependencies": {
    "@date-fns/utc": "1.1.1",
    "@dnd-kit/core": "6.1.0",
    "@dnd-kit/sortable": "8.0.0",
    "@formkit/auto-animate": "0.8.1",
    "@hookform/resolvers": "3.3.4",
    "@karabiner-inc/kbc-shared-components": "0.4.5",
    "@prisma/client": "5.8.1",
    "@remix-run/dev": "2.5.1",
    "@remix-run/node": "2.5.1",
    "@remix-run/react": "2.5.1",
    "@remix-run/serve": "2.5.1",
    "@shopify/app": "3.54.0",
    "@shopify/cli": "3.54.0",
    "@shopify/plugin-cloudflare": "3.54.0",
    "@shopify/polaris": "12.11.2",
    "@shopify/polaris-icons": "8.1.0",
    "@shopify/shopify-api": "8.1.1",  // Shopify
    "@shopify/shopify-app-remix": "2.2.0",  // Shopify remix
    "@shopify/shopify-app-session-storage-prisma": "2.0.3",
    "@tanstack/react-table": "8.11.7",
    "@vercel/remix": "2.5.1",
    "date-fns": "^3.3.1",
    "isbot": "4.4.0",
    "lodash": "4.17.21",
    "prisma": "5.8.1",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "react-hook-form": "7.49.3",
    "react-loading-skeleton": "3.3.1",
    "react-select": "5.8.0",
    "react-toastify": "10.0.4",
    "remix-hook-form": "4.0.1",
    "remix-utils": "^7.5.0",
    "zod": "3.22.4"
  },