Coder Social home page Coder Social logo

Comments (5)

chris-olszewski avatar chris-olszewski commented on June 9, 2024 2

I just double checked and we currently don't make use of that endpoint so you will be fine not implementing it.

I will update the OpenAPI spec to omit that endpoint.

from turbo.

chris-olszewski avatar chris-olszewski commented on June 9, 2024 1

Apologies for the confusion, both teamId and slug are valid query params for specifying which team you are using. If you connect your repository though something like turbo link, then a team id will be saved and teamId will be used when accessing the remote cache. TURBO_TEAM uses the slug query parameter instead since it isn't a team id.

Looking into fixing this in the upstream OpenAPI spec.

from turbo.

AdiRishi avatar AdiRishi commented on June 9, 2024

Hey @chris-olszewski , thanks for confirming this 😄
Looking forward to having this updated in the OpenAPI spec.

I had another question, I know this is off topic to the current issue, so happy to open a new one if you want.
I'm wondering if you could help explain what the POST /v8/artifacts route is supposed to do.
The docs say it has this input

{
  "hashes": [
    "string"
  ]
}

and gives this as an example for output

{
  "additionalProp1": {
    "size": 0,
    "taskDurationMs": 0,
    "tag": "string"
  },
  // ...
}

The output example is super unclear, I'm really not sure what data I'm meant to be returning here. What are the additionalProp keys? Is this saying that I have to echo the metadata even to the server via the /v8/artifacts/events endpoint?
Keen to get some clarity 🙏 . This is the last unimplemented endpoint I have left for my custom server.

from turbo.

chris-olszewski avatar chris-olszewski commented on June 9, 2024

OpenAPI spec has been updated to mention slug and teamId. Still working on fully removing the POST /v8/artifacts since it's unused.

from turbo.

AdiRishi avatar AdiRishi commented on June 9, 2024

Thanks Chris.
I'm happy to close out this issue, or keep it open until your other changes are synced, whatever you'd like

from turbo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.