Comments (9)
icyJoseph
commented on August 23, 2024
Related issue (?) feross/buffer#359
from next.js.
fraitag
commented on August 23, 2024
Probably yes. However, I am unsure about the specific version included in the Next.js polyfill. This library is precompiled and is not a Node.js package.
from next.js.
icyJoseph
commented on August 23, 2024
I'm guessing 5.x by looking at the compiled/vendored dependency.
On another note, why do you need Buffer in the browser? It is often a sign that code you don't mean to ship to the client, is making its way there, often through browserify
from next.js.
fraitag
commented on August 23, 2024
Absolutely, but the external library I use has protection against the lack of Buffer in the environment and executes the logic according to a different path. However, the nextjs mechanisms detect the presence of the word "Buffer" in the external module's code and add a polyfill (though it is not required because the library protects itself against it).
Which does not change the fact that since NextJS gives information that it supports Safari 12+, it also expects it.
from next.js.
icyJoseph
commented on August 23, 2024
Buffer doesn't exist in browsers though.
It is not just Buffer usage that triggers browserification of Buffer, often usage of crypto, or some Node.js modules, does as well.
Kind of a gray area situation here, can you try out on Safari 14, if the latest buffer (v6) npm package, does work? does v4 work?
from next.js.
fraitag
commented on August 23, 2024
Unfortunately, I wasn’t able to build Next.js correctly when I swapped out the Buffer version. I need more time for that. Would anyone else be willing to help?
My error:
from next.js.
icyJoseph
commented on August 23, 2024
Err, I meant more like:
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
<script src="https://bundle.run/[email protected]"></script>
<div>Hi</div>
</body>
</html>And open that in your Safari 14 browser. Try with 6.0.3 and 5.7.1, as well. Do you see the issue at all?
from next.js.
fraitag
commented on August 23, 2024
From bundle.run I do not have any errors, tested on Mojave Safari 12.1
from next.js.
icyJoseph
commented on August 23, 2024
Oh that's really, not what I had expected... 🤔
I searched for the compile PR from 3 years ago, and found that it was "buffer": "5.6.0", that was initially vendored in:
but that worked on your test...
If you copy the code from, https://github.com/vercel/next.js/blob/canary/packages/next/src/compiled/buffer/index.js#L5, and put it in a file.js and make a script pointing to it, rather than bundle.run, what do you get?
from next.js.
Related Issues (20)
- Please stop auto closing bugs like #50388! Don't put all the burden on reporters HOT 1
- Fast Refresh Failing to Work on New Project HOT 3
- NextJS 14 HMR Tailwind CSS reloading not working HOT 7
- app router - dynamic twitter card image generator file does not return anything if returned div has style: justifyContent: "end". HOT 5
- Docs: Misleading and potentially vulnerable example code of getting client's IP address HOT 5
- Error name is always overridden with "Error" HOT 1
- Problem with postcss transformation when importing css with layer HOT 1
- ReactRemoveProperties dosen't work as it was
- Turbopack dev server and HMR consuming too much memory and freezing at code changes. HOT 18
- TypeError: Failed to parse URL from /api/images HOT 9
- Vercel + pages router + basePath + middleware - Full roundtrip when client navigating to index page HOT 2
- Refractor languages missing when Turbopack is enabled
- "trailingSlash" causing CORS errors HOT 1
- Version 15 breaks select form element
- Docs: Versioned Documentation HOT 4
- Docs: inaccuracy in React Foundations (Chapter 4) HOT 4
- Sitemap is being generated incorrectly and an error in development also appears when I try to access /sitemap.xml HOT 13
- Cannot use Sharp in v15.0.0-canary.1 HOT 11
- NextJS 14 returns fetch failed with UND_ERR_CONNECT_TIMEOUT error on serverless function HOT 26
- enable swcMinify compression exception { toString, fromString } => {fromString} HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from next.js.