Coder Social home page Coder Social logo

Comments (6)

ztanner avatar ztanner commented on May 18, 2024

Hi @MrOxMasTer -- does the modal close for you if you add a @navigation/page.tsx component that returns null? If you're navigating to the index route, it's going to try and match @navigation/page.tsx rather than @navigation/[...catchAll] ([...catchAll] would apply to /foo, /foo/bar, but not /).

I can see how the docs are a bit unclear here, so I'll get those updated.

from next.js.

MrOxMasTer avatar MrOxMasTer commented on May 18, 2024

Hi @MrOxMasTer -- does the modal close for you if you add a @navigation/page.tsx component that returns null? If you're navigating to the index route, it's going to try and match @navigation/page.tsx rather than @navigation/[...catchAll] ([...catchAll] would apply to /foo, /foo/bar, but not /).

I can see how the docs are a bit unclear here, so I'll get those updated.

I deleted page.tsx to check, but it was there before and also didn't work on 14.2.3.

from next.js.

MrOxMasTer avatar MrOxMasTer commented on May 18, 2024

Hi @MrOxMasTer -- does the modal close for you if you add a @navigation/page.tsx component that returns null? If you're navigating to the index route, it's going to try and match @navigation/page.tsx rather than @navigation/[...catchAll] ([...catchAll] would apply to /foo, /foo/bar, but not /).

I can see how the docs are a bit unclear here, so I'll get those updated.

I read your comment about this and about the suggestion to support [[...catchAll]] in special routes and so also tried your way but it doesn't work still

from next.js.

MrOxMasTer avatar MrOxMasTer commented on May 18, 2024

image

from next.js.

ztanner avatar ztanner commented on May 18, 2024

Hi @MrOxMasTer -- does the modal close for you if you add a @navigation/page.tsx component that returns null? If you're navigating to the index route, it's going to try and match @navigation/page.tsx rather than @navigation/[...catchAll] ([...catchAll] would apply to /foo, /foo/bar, but not /).
I can see how the docs are a bit unclear here, so I'll get those updated.

I deleted page.tsx to check, but it was there before and also didn't work on 14.2.3.

I tried your provided reproduction and it works fine if I add a app/@modal/page.tsx component that returns null.

CleanShot.2024-04-26.at.14.05.12.mp4

Please provide an updated reproduction for us to look into this for you. Thanks!

from next.js.

MrOxMasTer avatar MrOxMasTer commented on May 18, 2024

Please provide an updated reproduction for us to look into this for you. Thanks!

So, I deleted the .next folder and ran it again and it worked!

Then let me ask you another question. Do I understand correctly that in this situation it can only lead to the home page? It seems logical, because the link is to the main page, but maybe somehow it can be realised by intercepts?

Because when testing on other pages, it doesn't return to the main page all the time.

from next.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.