Comments (3)
Hi,
Sorry I have missed this issue. Sounds really good to me. How would that work then, by throwing maybe?
from async-sema.
@OlliV I currently use a homegrown mini-version of async-sema
that implements just the functionality I needed from it. But it's, apart from the cancellation, API-compatible with it. When .cancel
is called it simply rejects all pending acquire
calls with an error that has a .code
property of 'CANCELLED'
. Anything similar to this to work for me. I'll include the code for that:
Code
/**
* @typedef {{ start: () => void, cancel: () => void }} Task
*/
// This is a very simplified version of https://github.com/zeit/async-sema
// But one that supports cancelling pending tokens
// can be replaced when/if this gets resolved
// https://github.com/zeit/async-sema/issues/31
class AsyncSema {
constructor (tokens = 1) {
this._tokens = tokens;
/** @type {Task[]} */
this._taskQueue = [];
}
_createTask () {
const task = { start: () => {}, cancel: () => {} };
/** @type {Promise<void>} */
const promise = new Promise((resolve, reject) => {
task.start = () => resolve();
task.cancel = () => reject(Object.assign(new Error('Task cancelled'), {
code: 'CANCELLED'
}));
});
this._taskQueue.push(task);
return promise;
}
_scheduleNextTask () {
if (this._tokens > 0) {
const nextTask = this._taskQueue.shift();
if (nextTask) {
this._tokens -= 1;
nextTask.start();
this._scheduleNextTask();
}
}
}
async acquire () {
const promise = this._createTask();
this._scheduleNextTask();
return promise;
}
release () {
this._tokens += 1;
this._scheduleNextTask();
}
async cancel () {
const toCancel = this._taskQueue.splice(0, this._taskQueue.length);
for (const task of toCancel) {
task.cancel();
}
}
}
from async-sema.
Cool! 👍
Sorry for the delay, it's hard to keep up with all the notifications.
from async-sema.
Related Issues (17)
- Possible p() & v() confusion HOT 2
- broken typescript definition HOT 3
- Action required: Greenkeeper could not be activated 🚨
- Add examples to README
- Make it OSS
- Intuition surrounding `nr` values
- Rate limit and throttle: Last item throttled HOT 2
- .release() does not check actual token count HOT 3
- Some nice way of async iterating? HOT 6
- IE 11 Support HOT 3
- Args object should be optional
- Add Sema.run utility for easy task processing
- RateLimit does not work with number less than 1. HOT 2
- Uncaught TypeError: Class extends value #<Object> is not a constructor or null HOT 1
- Is it possible to make 1 request every 2 seconds? HOT 1
- What is the `nr` variable? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from async-sema.