Comments (12)
Hi Mister grant sorry for pinging you 🚎
Hi Ven, it's ok. I get about 1 ping every day because of my name. You are the first to apologize in advance. Have a good day!
from vencord.
it would be trivial to have a gh action compile vencord and create a build artifact that can be used for the downloadURL
from vencord.
Violentmonkey on Firefox currently has an issue where Object.defineProperty
on window
at @run-at document-start
doesn't work, meaning webpack patching won't work.
from vencord.
Itls à good idea
from vencord.
Added in d26196d
Works fine except that Firefox ViolentMonkey bug cyn mentioned. Also runs into csp issues when trying to fetch external urls like github/unpkg
I am not sure how to fix these two issues
from vencord.
I don't think there's a way to fix the CSP issue without doing a big refactor to use a @grant which means window -> unsafeWindow and it just overcomplicates things. I solved the issue in the proper browser addon by making a background script but this is not possible in UserScripts. The best solution would probably to use an anti csp extension like this one (Disclaimer: I never used it and have no idea whether it works and is safe) unless someone else has a better idea / could contribute a solution.
In any case, CSP bypass isn't even that important, only minor features like petpets dynamic library import from cdn don't work so I think it's fine
from vencord.
Hi Mister grant sorry for pinging you 🚎
from vencord.
For the purposes of having a version number that increments for auto-updating the userscript, could we use the commit number via e.g. git describe
?
from vencord.
Doesn't its updating system use semver?
from vencord.
Updating should work now since it just uses the current timestamp as version. I don't think csp bypass is doable from userscript, so this issue is basically done now
from vencord.
Aren't there several userscript APIs to circumvent CSP in some cases? GM_addElement
, GM_getResourceURL
, and GM_xmlhttpRequest
.
from vencord.
please don't necro old resolved issue threads. this issue is more than a year old
yes, those would likely work for some use cases, but that would require us to write specialised UserScript code, which is out of scope, and would still not cover some other use cases. not to mention, tampermonkey already seems to have workarounds for csp issues with which multiple people reported success
from vencord.
Related Issues (20)
- [Bug] ShowHiddenChannels is NOT working properly!
- [Bug] Transparent window prevents hideable taskbar from showing. HOT 1
- [Bug] TypingIndicator not working until channel is navigated to HOT 1
- [Bug] themes don't work HOT 5
- [Bug] <Always animate isn't working> HOT 1
- Crashing when opening someones stream HOT 4
- [Bug] Many plugins in version 650f405 are BROKEN HOT 2
- Discord Update broke a lot of plugins
- [Bug] PinDMs: alt up/down doesn't work correctly when using recent message sort order HOT 3
- [Bug] Volume Booster: Volume only goes to 200%, 201-400% automtically reset.
- [Bug] can't decrypt messages HOT 1
- [Bug] Trojan detected by windows defender in VencordInstallerCli.exe HOT 4
- [Bug] NoMosaic plugin is broken
- [Bug] RoleColorEverywhere broken in voice users list HOT 6
- [Bug] ReadAllNotificationsButton read error HOT 2
- [Bug] <title> I HAVE INSTALLED EVERY THING I NEED TO FOR THE BROWSER VERSION HOT 2
- [Bug] Vencord is not working whien switching to another account HOT 2
- [Bug] MemberCount showing 0 online members while viewing threads HOT 5
- [Bug] <title>3y3 button not appearing HOT 3
- [Bug] MessageLogger fails to log the second to last version of any message's edit history if the last edit made to the message matches the message's original content. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vencord.