Coder Social home page Coder Social logo

Comments (3)

LandonTClipp avatar LandonTClipp commented on June 14, 2024

@DustinJSilk

It took me a minute to wrap my head around the question but I think I understand. This is basically a self-referential problem coming from the fact that .Clone() is returning the same generic type that was used when instantiating the mocks.MockClient type. This loop is generated when providing concrete types to the generic constraints:

mockRepository :=mocks.NewMockRepository[*testing.T, *mocks.MockClient[*mocks.MockClient[*mocks.MockClient[etc. forever and ever]]](t)

I forked your example and manually modified the mocks to provide a completely working example of what we would ultimately want mockery to generate: LandonTClipp/mockery-cloneable@d18f1dd

The proposal is to add new config parameters that allow mockery to replace the generic constraints with concrete types. The changes I made to the mock implementation should be what mockery would generate.

My questions for you:

  1. Does my fork of your reproducer seem to actually fix your problem?
  2. Would you be willing to submit a PR for this, assuming we both agree on the solution I proposed?

from mockery.

DustinJSilk avatar DustinJSilk commented on June 14, 2024

Hi @LandonTClipp ,

Thanks for taking the time to look into this!

  1. Yes it does, I ended up manually editing the mocks in the same way in my project and it works as expected.
  2. I'm happy to have a crack at it over the next few days when i get a moment

from mockery.

LandonTClipp avatar LandonTClipp commented on June 14, 2024

Okay great. It would be much appreciated if you could try for an implementation here. Otherwise, I can probably do it myself sometime in the next few weeks. Although, this is such a rare situation that it might get thrown behind some other high priority tasks.

from mockery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.