Shoreline error bugout? about rivgraph

[jonschwenk]

Did you look at the shoreline I made for your mask? I linked to it in another issue, but here it is again: https://drive.google.com/open?id=1mYE-PkJ5lB5S2OkZ8jkmEbgIDyJtJtsS

[Lvulis]

Yep and it worked perfectly! Should have noted last night I also got my installation to get up to assigning directionality but can't resolve a cycle. So here the issue is something with the shoreline I used. I will look at it more in a bit. was hoping this may be useful for you - is the error informative at all? If I get the same on error on another delta does that mean I need to adjust my shoreline by x or y?

[jonschwenk]

Not sure. The shoreline should only intersect links at outlets, or links that will be removed during spur pruning. It should effectively delineate two separate subnetworks--the one you want to keep, and the one "in the ocean." So your initial shoreline that surrounded the entire delta would likely throw some weird errors.

[Lvulis]

Ok that makes sense, i was mostly concerned with the tidal/ice zone on the northern edge. On my phone but noting your comment in the doc would be extremely helpful (although this may just be because I'm using masks I defined for the shrinkage analysis)

[Lvulis]

OK issue resolved:

The shoreline I used had these two fields, LEFT_FID and RIGHT_FID. This was causing the cut_link_ids to all be -1. I changed the fields to match that of your shoreline and it worked. So solution is to have id as a field with NA as the entry. I also fixed my shoreline to be the actual shoreline.

Using my own shoreline/inlet nodes I am now able to use RG from start to assigning directionality. I'm not using the graph metrics for now but probably will soon - will let you know if more errors arise.

[jonschwenk]

I should make these header names explicit instead of relying on the default (seemingly changing) geopandas labels.

[Lvulis]

It seems that the "LEFT_FID" is not geopandas fault by the way but some issue with how it was generated originally (in Arc). If by header names being explicit you mean stating what fields the shoreline file should have, agreed!

[jonschwenk]

This has been addressed in the docs now: https://jonschwenk.github.io/RivGraph/issues/index.html