Coder Social home page Coder Social logo

Comments (4)

mraible avatar mraible commented on July 20, 2024

I figured out how to do it! http://stackoverflow.com/a/27787545/65681

from spring-boot-security-saml-sample.

vdenotaris avatar vdenotaris commented on July 20, 2024

Hi. I'm sorry but I have to reject your pull request because it doesn't provide relevant improvements.

  • the use of a .properties file (instead of a .xml) is yet compliant with the Log4j Spring Boot Starter;
  • it is possible to manage all Spring-core dependencies by using a Maven BOM called Spring Platform (see http://platform.spring.io/platform/);
  • your pull request contains IDE-related metadata that makes the code dirty.

Furthermore, this project represents a general-purpose solution. It is preferable to create specific forks in order to properly integrate third-party frameworks (like Okta).

Thank you anyway for your contribution and attention.
Cheers, Vi.

from spring-boot-security-saml-sample.

mraible avatar mraible commented on July 20, 2024
  • Yes, but I changed to use the Log4j2 starter and this requires a log4j2.xml file.
  • Yes, but Spring Boot seems to recommend using its parent over the Spring Platform BOM. http://projects.spring.io/spring-boot/#quick-start Also, you can't manage plugin versions and information with a BOM import.
  • It's only in the .gitignore file. The current one has an ignore for "Mobile Tools for Java (J2ME)", which seems irrelevant as well.

from spring-boot-security-saml-sample.

mraible avatar mraible commented on July 20, 2024

Using Spring Boot as a parent also eliminates these warnings on startup:

$ mvn spring-boot:run
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for com.vdenotaris.spring:spring-boot-security-saml-sample:war:1.0.0.RELEASE
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 133, column 12
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-war-plugin is missing. @ line 127, column 12
[WARNING] 'build.plugins.plugin.version' for org.springframework.boot:spring-boot-maven-plugin is missing. @ line 118, column 12
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.

from spring-boot-security-saml-sample.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.