A bunch of changes about go-livestatus

[vbatoufflet]

Hi,

I welcome all improvements or additional support for this package.

That said, looking at the documentation form your fork, the commands list is quite huge and do bloats the package.

Maybe it could be implemented using variadics (e.g. func (c *Command) Exec(name string, args ...interface{})), then calling it like this:

c.Exec("CHANGE_CUSTOM_HOST_VAR", "host1.example.net", "foo", "bar")
c.Exec("DISABLE_HOST_EVENT_HANDLER", "host1.example.net")
c.Exec("ENABLE_PERFORMANCE_DATA")

WDYT?

[tcolgate]

The original implantation looked a bit like that, buy I want a degree of
type safety.
Theres a raw interface buried in there. How about I leave that at the top
level and add a nagios subpackage with the noise in?
The awkward thing is that there's no response on COMMAND at all, so
having a type checked interface is a big win

On Sat, 25 Jun 2016, 18:53 Vincent Batoufflet, [email protected]
wrote:

Hi,

I welcome all improvements or additional support for this package.

That said, looking at the documentation form your fork, the commands list
is quite huge and do bloats the package.

Maybe it could be implemented using variadics (e.g. func (c *Command)
Exec(name string, args ...interface{})), then calling it like this:

c.Exec("CHANGE_CUSTOM_HOST_VAR", "host1.example.net", "foo", "bar")
c.Exec("DISABLE_HOST_EVENT_HANDLER", "host1.example.net")
c.Exec("ENABLE_PERFORMANCE_DATA")

WDYT?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAEo8xnIAKSPw2MQY2abGxNJUSiodGM8ks5qPWsogaJpZM4I925_
.

[tcolgate]

Sorry, autocomplete made a right mess of that! Hopefully you got the gist
of it.

On Sat, 25 Jun 2016, 19:31 Tristan Colgate, [email protected] wrote:

The original implantation looked a bit like that, buy I want a degree of
type safety.
Theres a raw interface buried in there. How about I leave that at the
top level and add a nagios subpackage with the noise in?
The awkward thing is that there's no response on COMMAND at all, so
having a type checked interface is a big win

On Sat, 25 Jun 2016, 18:53 Vincent Batoufflet, [email protected]
wrote:

Hi,

I welcome all improvements or additional support for this package.

That said, looking at the documentation form your fork, the commands list
is quite huge and do bloats the package.

Maybe it could be implemented using variadics (e.g. func (c *Command)
Exec(name string, args ...interface{})), then calling it like this:

c.Exec("CHANGE_CUSTOM_HOST_VAR", "host1.example.net", "foo", "bar")
c.Exec("DISABLE_HOST_EVENT_HANDLER", "host1.example.net")
c.Exec("ENABLE_PERFORMANCE_DATA")

WDYT?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAEo8xnIAKSPw2MQY2abGxNJUSiodGM8ks5qPWsogaJpZM4I925_
.

[tcolgate]

@vbatoufflet I've moved the nagios specific stuff into a sub-package. I'm using a sort of functional option style, but that might be overkill. At present it should work something like

lv.Command().Op(nagios.AcknowledgeHostProblem(...))
lv.Exec()

which felt a bit more in keeping with the current style.Alternatively it could just be:

lv.Command()
nagios.AcknowledgeHostProblem(lv, ....)
lv.Exec()

But I don't think that reads as well.

I'll break up the current code into a 3 PRs and send them over (by the end of the week I hope)