htole64 / le64toh on old glibc about pixz

[wookietreiber]

Do you know which glibc version introduced both htole64 and le64toh? We should apply these defines only for glibc version lesser than the one introducing these.

[wookietreiber]

Apparently, they are introduced in glibc 2.9. I think, the best way to address this is to check for both of these functions in configure and if they do not exist, define them ourselves.

[cicku]

Being as a person dealing with RHEL for several years, I'd say RHEL6 ships GLIBC 2.12.

[andreasstieger]

As a correction to the original report, this affects CentOS 5 and RHEL 5 which have glibc-2.5, not 6. So yes this is a portability issue for glibc < 2.9.

[wookietreiber]

@andreasstieger would you please test this patch on both RHEL 5 and RHEL 6 (alternative to the patch, you can checkout the endian-conversion-checks branch on my fork)?

[andreasstieger]

👌 wookietreiber@5d831e6 works as intended on all affected targets, does not break others and would fix this issue.

[wookietreiber]

Great, @andreasstieger thanks for reporting back. I am going to merge and cut a new release.

[wookietreiber]

Done, new release is up.