Comments (1)
Thanks @Bassel-Bakr for the feedback!
Here are my 2 cents on the issue:
- Neither
!==
or!Object.is
is perfect solution. For!==
, we haveNaN !== NaN
beingtrue
. For!Object.is
, we have!Object.is(0, -0)
beingtrue
. - This is probably not a significant issue. The worst outcome is we would fail to skip propagating state changes and re-render DOM when we indeed can skip (i.e.: when the new value in the
s.val = <new value>
call is semantically the same as the existing one). Thus we're just wasting some computation in rare circumstances. This will not cause any semantic issue for apps built with VanJS. - Among 2 options, I personally believe
!==
is slightly better than!Object.is
. We might encounter the comparison between0
and-0
more often than the comparison betweenNaN
andNaN
, asNaN
shouldn't usually occur for a semantically correct app.
from van.
Related Issues (20)
- How to get access to DOM elements (like refs in React) HOT 2
- VanJS Router? HOT 5
- State change in setInterval HOT 6
- Conditional root rendering HOT 6
- Reactivity is broken when the context is quickly switched HOT 5
- It doesn't work. Did I do something wrong? HOT 9
- Update Van JSX HOT 5
- Abnormal behavior under the input box. HOT 4
- vanX.list also looping empty values HOT 2
- Add a callback with just created element HOT 2
- Lifecycle event: mount and unmount HOT 1
- Error on when using method for Date data in VanX reactive (and possibly all class instance). HOT 4
- Download table broken HOT 2
- how to manually re-render? HOT 8
- Clear reactive array HOT 18
- Script children should not be escaped HOT 6
- Intersection observer HOT 11
- Can createDocumentFragment be used directly? HOT 2
- Smallest reactive library HOT 6
- A way to make VanJS even smaller HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from van.