Coder Social home page Coder Social logo

Comments (4)

valorkin avatar valorkin commented on June 12, 2024

interesting, need to think about it
it could be an edge case or a common use case
but I will take this in consideration for sure

from ng2-select.

ronzeidman avatar ronzeidman commented on June 12, 2024

Thanks, might be just an edge case but you could probably make the fix small and simple.
you could probably get away with just the second check:

if (e.srcElement && e.srcElement.className &&
    e.srcElement.className.indexOf('ui-select') >= 0 && 
    (!e.target || e.target.nodeName !== 'INPUT')) {
        this.matchClick(null);
}

and because this is not a global handler you don't need to save the listener and clean it on destroy so just:

this.element.nativeElement.addEventListener('click', (e) => this.clickHandler(e));

will do without the need of the saved closure.

It will help me since I'm using this edge case, I don't think it's very common usecase to put a select inside a dropdown, but maybe people will "stop propagating" clicks for other reasons, so I guess it's not a priority.

from ng2-select.

valorkin avatar valorkin commented on June 12, 2024

actually I should only stop bubbling an event, most probably

from ng2-select.

ronzeidman avatar ronzeidman commented on June 12, 2024

Yea, will be much cleaner, BTW I think this will also fix issue #22 (two selects on one view issue) which is a much more common issue.

from ng2-select.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.