Comments (4)
interesting, need to think about it
it could be an edge case or a common use case
but I will take this in consideration for sure
from ng2-select.
Thanks, might be just an edge case but you could probably make the fix small and simple.
you could probably get away with just the second check:
if (e.srcElement && e.srcElement.className &&
e.srcElement.className.indexOf('ui-select') >= 0 &&
(!e.target || e.target.nodeName !== 'INPUT')) {
this.matchClick(null);
}
and because this is not a global handler you don't need to save the listener and clean it on destroy so just:
this.element.nativeElement.addEventListener('click', (e) => this.clickHandler(e));
will do without the need of the saved closure.
It will help me since I'm using this edge case, I don't think it's very common usecase to put a select inside a dropdown, but maybe people will "stop propagating" clicks for other reasons, so I guess it's not a priority.
from ng2-select.
actually I should only stop bubbling an event, most probably
from ng2-select.
Yea, will be much cleaner, BTW I think this will also fix issue #22 (two selects on one view issue) which is a much more common issue.
from ng2-select.
Related Issues (20)
- Angular 10 support? HOT 2
- Is anyone know any alternative of ng2-select library? HOT 2
- Can't bind to 'multiple' since it isn't a known property of 'ng-select' HOT 1
- 使用ng2-select进行响应式表单验证问题
- t directive
- Multiselect with checkboxis ?
- text property in items can't be Number
- How to add Tooltip in ng2-selsect
- Avoid & in ng-select drop down in angular 7 HOT 1
- getting ng2SelectEmptyError for optional dropdown
- Input data was spoiled after typing special chars!
- ng2-select not working after upgrade to Angular 8 HOT 7
- How to clear Validate when using with FormControlName
- Hi all:
- How to set a value requested from an API HOT 1
- Breaks with Ivy HOT 6
- Problem with nested array
- disable automatic focusToInput
- Is this lib dead? HOT 3
- No css file in docs or even in project
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ng2-select.