Comments (4)
I suppose another option would be to allow specifying an error handler in the API, which get's called if the API fails. That would allow us to better support the error case.
@PingXie Just want to get your opinion on this. I think we should do three things:
- Change connSetHandler so it returns a void.
- Attempt to handle the case where an fd is out of bounds by doing an in-place realloc of the array and log a message.
- Call the error handler when we encounter an error.
from valkey.
Both 1) and 2) make sense to me. Can you elaborator on 3)? I am not sure which error handler this is. If we can realloc, there isn't much for the caller to handle anyway; but if we can't, I think we have a bigger issue.
from valkey.
but if we can't, I think we have a bigger issue.
I guess I just don't know if we actually have bigger issues. Today we might just be silently ignoring issues on error paths which get resolved later. I can imagine there are cases where a client was accepted, has already been closed by the file system by some later time we install the handler, and we gracefully ignore the epoll_ctl command since the client will get eventually closed anyways.
So, my thought for the error handler, is just to make sure we aren't "leaking" the client resource (for the normal client case) and the clusterbus (in the cluster case). If after some time in product we don't observe any issue, we could remove it.
from valkey.
If we do 1) and 2), we will be able to handle all errors internally to aeApiAddEvent
so we probably don't need an error handler callback. Should we consider a fix in Valkey 8.0?
from valkey.
Related Issues (20)
- Blocking commands are marked as being nested
- [NEW] Enhanced Function API: off-thread JSON/MsgPack decoding of args and encoding of response HOT 1
- [Daily CI] Based line for Daily CI status (All test cases can passed)
- [BUG] `CLIENT CAPA redirect` may result in bouncing redirects during failover HOT 10
- [BUG]In big cluster Redis (Valkey) replica node is not able to sync since 6.2.11 HOT 2
- [NEW] Introduce server level network ingress / egress metrics for cluster bus. HOT 1
- [BUG] Replica can run cross-slot MULTI/EXEC, upon module hooks on primary HOT 2
- [Test failure] IO error with TLS
- [BUG] The result of the PING command does not match the documentation when using RESP3 HOT 1
- [BUG] A large negative number(e.g. -LONG_MAX) in HRANDFIELD/ZRANDMEMBER can easily cause Valkey to crash. HOT 2
- [NEW] Migrate from Redis 7.4.0 to Valkey 7.2.5 HOT 9
- [NEW] Introduce slot-level memory metrics
- [Test failure] Test issues with empty shard migrations
- [BUG] "CLIENT CAPA redirect" has no effect in scripts HOT 1
- [BUG] Cluster: Inconsistent MOVED/READONLY errors for read-only client
- [NEW] Introduce a new client capability for throttling
- [NEW] Add support for setting the group on a unix domain socket HOT 1
- Feature Request: Add Error Status Field for Diskless Syncs HOT 5
- [NEW] HTTP support for Valkey HOT 4
- [NEW] Support proxy protocol HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valkey.