Comments (5)
Adding a new alias for the word server
seems very risky. I can easily imagine that there are already lua scripts with the word server
in them. valkey
would seem safer.
from valkey.
@daniel-house Good point. If script uses a variable named server
, they will get an error like I got here:
127.0.0.1:6379> eval 'server = "hello" return server' 0
(error) ERR user_script:1: Attempt to modify a readonly table script: eaea3495a27b17adb01815dd404912e3f3623d10, on @user_script:1.
@valkey-io/core-team Shall we add a valkey
Lua object instead?
I don't think it's a problem actually. Users can only create local variables. It's already possible to create a local variable called redis:
127.0.0.1:6379> eval 'local redis redis = "qux" return redis' 0
"qux"
from valkey.
Yeah, you have to create local variables. Someone might already be creating a local server that would shadow the global variable, but that shouldn't break their script. It is a valid callout that some folks might need some soft refactoring if they were declaring a local server variable, which would shadow the global one. I don't see a concern.
from valkey.
(Assigning it to me, although someone else from AWS is working on it. I'll update assignment when they join the triage group)
from valkey.
Fixed by #213
from valkey.
Related Issues (20)
- Investigate using path filters to reduce the number of tests we are running
- Investigate performance improvements related to slot ownership in getNodeByQuery HOT 8
- Request for Valkey to support element level TTL for hash, set and sorted set HOT 4
- [BUG] Stream lag value could be incorrect HOT 1
- [NEW] Add "Total" message and used_memory_human log information in serverCron() function
- Changing Valkey RDB magic for Valkey 8 HOT 14
- [DOC] Document the clang-format flow HOT 2
- Test failure unit/cluster/slot-migration
- Revise config defaults for Valkey 8 HOT 12
- [NEW] Improve cluster logs HOT 1
- GEOSEARCHSTORE - ASC | DESC options are meaningless HOT 2
- Extended Valkey client introspection functionality HOT 3
- Valkey support for memory locking (?) HOT 4
- Memory protected (debug) mode HOT 2
- Introduce new rax function `raxAllocSize` to return rax tree allocation size in constant time HOT 12
- Parallel execution of read operations HOT 1
- [NEW] Please publish Debian artifacts HOT 6
- [NEW] Add the test scenario of `io-uring-enabled yes` to daily test.
- Introduce a minimal debugger for .tcl integration test suite
- Optimize code path of `prepreClientToWrite`.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from valkey.