Coder Social home page Coder Social logo

Comments (4)

jhristov avatar jhristov commented on August 20, 2024 1

What I found is a couple of issues in OutputSignalTracker which prevent the pitch output. First, installTap() has no effect on audioEngine - one has to substitute with audioPlayer. Second, the delegate in the closure was always nil so self.delegate?.signalTracker() was never called. Here is my replacement code which should give you an idea how to get some readings. It goes in the start() method of OutputSignalTracker. One must import Pitchy too.

      let factory = EstimationFactory()
      let estimator = factory.create(.yin) // Choose pitch method here!
      let queue = DispatchQueue(label: "BeethovenQueue", attributes: [])

      self.audioPlayer.installTap(onBus: 0, bufferSize: self.bufferSize, format: nil) { (buffer, time) in
          
          queue.async { [weak self] in
            guard let `self` = self else { return }

            do {
              let transformedBuffer = try estimator.transformer.transform(buffer: buffer)
              let frequency = try estimator.estimateFrequency(
                sampleRate: Float(time.sampleRate),
                buffer: transformedBuffer)
              let pitch = try Pitch(frequency: Double(frequency))
            print(time,pitch)

              DispatchQueue.main.async { [weak self] in
                guard let `self` = self else { return }
                //self.delegate?.pitchEngine(self, didReceivePitch: pitch)
              }
            } catch {
              DispatchQueue.main.async { [weak self] in
                guard let `self` = self else { return }
                //self.delegate?.pitchEngine(self, didReceiveError: error)
              }
            }
        }
          
    }

One would then start the tracking with:

        let config = Config(
          bufferSize: 4096,
          estimationStrategy: .yin, // has no effect, has to be set in the estimator, see above
          audioUrl: Bundle.main.url(forResource: "sound_file", withExtension: "wav")!
        )
        
        let pitchEngine = PitchEngine(config: config)
        pitchEngine.start()

from beethoven.

kocharyanvahe avatar kocharyanvahe commented on August 20, 2024

Also, I have the same problem.

from beethoven.

hepiyellow avatar hepiyellow commented on August 20, 2024

Yeah, Can you give an example of how to analyze an audio file and get the Pitch array or something?
And, how would I know the timing info (offset in milliseconds) of each Pitch sample?

from beethoven.

mannyvw avatar mannyvw commented on August 20, 2024

@jhristov perfect. Yep i replaced the following line in OutputSignalTracker::start

audioEngine.outputNode.installTap(onBus: bus, bufferSize: bufferSize, format: nil)

With

audioPlayer.installTap(onBus: bus, bufferSize: bufferSize, format: nil)

and everything else works. Good work

from beethoven.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.