Include un-minified VaadinGridImport.nocache.js about vaadin-grid

[jouni]

Hi @jhawlwut!

Sorry for being late with the reply, I completely forgot!

As for VaadinGridImport.nocache.js, it’s actually generated JavaScript, compiled from the GWT source code for the grid. v-grid is actually a Web Component wrapper for the Vaadin Framework Grid component (see https://vaadin.com/grid), and the original implementation is written in Java.

So you should never modify the compiled JS code. You can generate a human readable version of the file if you want to, though. There are instructions in the readme how to set up the project and how to compile it.

I’m not sure if it would be helpful to include the unobfuscated version of the compiled JS in the release package. Perhaps for debugging, but since you can’t do the fix in the JS code, I don’t really see the point.

[jouni]

Closing, since I don’t think we will ever publish the unobfuscated JS, it really doesn’t serve the users. It might just give the wrong idea that it can be directly modified.

If you wish to debug the generated JS, you can use the "pretty" output option described in the readme: https://github.com/vaadin/vaadin-grid#development-protips

[ktiedt]

I have to disagree with this logic...

1. unobfuscated code does not promote 'editing the file directly' - it does however promote troubleshooting and opening more detailed bug reports, or pull requests to fix the bug because they were able to quickly and easily delve into the code and with minimal effort, find and fix it.

2. It also allows for developers to work the compressing into their workflow which may include extern and or SourceMap generation to aide in their development process.

Please don't limit your users ability to help themselves AND your team in making vaadin-grid even better.

[Saulis]

Here's the <vaadin-grid> 0.9.0-beta5 compiled with pretty (ugly) formatting:
https://gist.github.com/Saulis/2037bcebfe217251df62

If someone finds this helpful in any way, we might reconsider including the prettified JS in our packaging.

[ktiedt]

Yeah, Marcus showed me this yesterday, the fact that this is generated from
GWT didnt really register initially. The 'pretty' code is almost as bad as
the minified code :(

-Karl Tiedt

On Thu, Nov 12, 2015 at 12:24 AM, Sauli Tähkäpää [email protected]
wrote:

Here's the 0.9.0-beta5 compiled with pretty (ugly)
formatting:
https://gist.github.com/Saulis/2037bcebfe217251df62

If someone finds this helpful in any way, we might reconsider including it
in our packaging.

—
Reply to this email directly or view it on GitHub
#101 (comment).

[vbolshutkin]

While trying to make vaadin grid work under Ionic 2 application I encountered very strange issue only in FF. So, I would find helpful if human-readable version was available at cdn near https://cdn.vaadin.com/vaadin-core-elements/latest/vaadin-grid/vaadin-grid.min.js .

Using the gist above I was able to match a bit outdated unminified code with latest minified and find a workaround. But to understand the initial cause and fix it I will definitely need a latest human-readable version.

[vbolshutkin]

Tried to build my own according to instructions, but Maven 3.3.3 failed to resolve dependencies (at both master branch and v1.2.1 tag).

[ERROR] Failed to execute goal on project vaadin-grid: Could not resolve dependencies for project com.vaadin.elements:vaadin-grid:war:1.2.0: Failed to collect dependencies at com.vaadin:vaadin-widgets:jar:7.7.0.elements3: Failed to read artifact descriptor for com.vaadin:vaadin-widgets:jar:7.7.0.elements3: Failure to find com.vaadin:vaadin-root:pom:7.7.0-SNAPSHOT in http://repo1.maven.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]

[manolo]

For some reason there is a dependency missing in maven repos.
In the meanwhile we fix the issue, you can change <vaadin.version>7.7.0.elements3</vaadin.version> by <vaadin.version>7.7.0.elements2</vaadin.version> in java/pom.xml

[platosha]

@vbolshutkin I would recommend you to try upgrading to grid 2.0 already. It was completely rewritten in JavaScript, should be a bit easier to debug.

The latest release is v2.0.0-alpha4. No need to upgrade Polymer, we are still using Polymer v1.x in <vaadin-grid> v2.0. See this wiki page for the API changes: https://github.com/vaadin/vaadin-grid/wiki/Migration-from-1.*-to-2.0