Coder Social home page Coder Social logo

Comments (4)

pleku avatar pleku commented on August 16, 2024

@tmattsso can you please clarify what is strange ??

from beverage-starter-flow.

tmattsso avatar tmattsso commented on August 16, 2024

I mean this:
title.addClassName("main-layout__title")

why not just set main-layout for the main layout itself, instead of those weird concatenations

from beverage-starter-flow.

pleku avatar pleku commented on August 16, 2024

@jouni can clarify, I was the reviewer and just trusted him

from beverage-starter-flow.

jouni avatar jouni commented on August 16, 2024

Yeah, they are probably strange to Java developers, and I should’ve discussed this with the team.

Front-end devs should recognize BEM when they see it. But, we should perhaps not use BEM in any of our products, and instead always use a new custom element with shadow dom when we want to ensure that styles are properly scoped and easier to maintain. After all, that’s what BEM tries to provide.

So, I’m okay if we want to update the class names. But, we should not encourage bad practices, and at least encapsulate the header/nav bar into a separate component with its own style scope.

from beverage-starter-flow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.