Comments (4)
@tmattsso can you please clarify what is strange ??
from beverage-starter-flow.
I mean this:
title.addClassName("main-layout__title")
why not just set main-layout for the main layout itself, instead of those weird concatenations
from beverage-starter-flow.
@jouni can clarify, I was the reviewer and just trusted him
from beverage-starter-flow.
Yeah, they are probably strange to Java developers, and I should’ve discussed this with the team.
Front-end devs should recognize BEM when they see it. But, we should perhaps not use BEM in any of our products, and instead always use a new custom element with shadow dom when we want to ensure that styles are properly scoped and easier to maintain. After all, that’s what BEM tries to provide.
So, I’m okay if we want to update the class names. But, we should not encourage bad practices, and at least encapsulate the header/nav bar into a separate component with its own style scope.
from beverage-starter-flow.
Related Issues (20)
- Watcher should not be executed on a regular `mvn package`. HOT 1
- babel generates cache stuff in `src/main/webapp/node_modules` HOT 2
- dev-mode perf: Avoid ES5 transpilation if not developing in IE11 HOT 3
- Include watcher into the maven plugin to detect changes for templates HOT 2
- Update README for alpha1 HOT 1
- stats.json file is "corrupt" HOT 8
- Move frontend folder in the root folder.
- SPIKE: investigate whether to replace jetty with tomcat HOT 2
- There's an Internal Error when click on Categories. HOT 2
- Remove bower-related annotations from the starters HOT 1
- Unstaged files after running HOT 1
- DARK theme makes category unreadable HOT 1
- Lumo theme with DARK variant does not work with IE11 HOT 1
- Error when running the starter with V14 beta 1 on tomcat HOT 2
- Application is broken HOT 8
- Styling is a bit different between MS edge and chrome/firefox
- Use client-side bootstrapping in Beverage Buddy
- Use client-side routing in Beverage Buddy
- ERROR in [at-loader] TS2688: Cannot find type definition file for 'glob'
- Style issues with V17.rc1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beverage-starter-flow.