Comments (8)
Having separate RxMoviesService, etc, classes and an optional dependency on RxJava would probably not cause any issues for existing users tho
from tmdb-java.
I've pushed a fork with support for Kotlin and RxJava2. But it's built as an Android Gradle library not a pure Java artifact.
https://github.com/sevar83/tmdb-rxjava2-kotlin
from tmdb-java.
I created a fork, and relative pull request, in wich i duplcated all the services that return Observables.
All the new Services can be found into the class Tmdb.rx
https://github.com/serafo27/tmdb-rxjava
from tmdb-java.
No need since Retrofit2 already supports RxJava. Indeed, it supports every interface through call adapters
Add this library:
compile 'com.jakewharton.retrofit:retrofit2-rxjava2-adapter:1.0.0'
And extend the Tmdb class to add the support.
class RxTmdb extends Tmdb {
protected Retrofit.Builder retrofitBuilder() {
return super.retrofitBuilder().
.addCallAdapterFactory(RxJava2CallAdapterFactory.create());
}
}
from tmdb-java.
@urizev But you still would have to change all the service method return types, no? Like:
@GET("search/movie")
Call<MovieResultsPage> movie(...);
has to be changed to:
@GET("search/movie")
Observable<MovieResultsPage> movie(...);
@NathHorrigan In any case, you should create a fork of this library and make the necessary adjustments (find/replace return types, add call adapter). Adding any possible RxJava method seems not useful.
from tmdb-java.
@UweTrottmann Yes, you're right. I didn't realize. 😞
from tmdb-java.
I'll create a fork and let you know how it goes :)
from tmdb-java.
I derived my local RxJava1 tmdb service and just using the entities. I guess we need 1 main (entities + Call) and 2 additional optional artifacts - RxJava and RxJava2. Don't know this packaging stuff well but you could check out how it is done in RxBinding for example.
from tmdb-java.
Related Issues (20)
- Istancing new Tmdb launches excpetion HOT 1
- Discover Api call doesnot get any genres into the Movie object HOT 2
- Translations are missing HOT 1
- Remove myself from pom.xml if Sonatype OSSRH allows it HOT 2
- Update supported API calls HOT 1
- Find results should return base media classes
- TMDb Unsynced Servers
- TaggedImage Entity Missing Fields
- On Video entity type field can be ENUM
- On TestData Actor's Origin place has been updated
- MovieService may be broken HOT 2
- 2.2.0 Version not in maven central HOT 1
- Provide existing configured OkHttpClient HOT 2
- Update Entity IDs to Long?! HOT 3
- include_adult missing for search.tv method HOT 3
- Vote avaerage and vote count are missing HOT 1
- Tv tagline is missing HOT 1
- spoken languages for series is missing HOT 1
- Add trending endpoint HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tmdb-java.