No memory allocated for snow band arrays when using ARC_SOIL == TRUE about vic

[tbohn]

I agree - option 2 is more in line with our general trend towards simplifying the code. Maintaining the arcinfo option requires updating both pathways (regular and arc) for any changes to soil parameters.

[bartnijssen]

Bug was caught with:

• VIC version 4.1.2.j
• Ubuntu 13.10 (64 bit)
• GUI C complier (gcc), version 4:4.8.1-2ubuntu3

Reproduced with:

• VIC version 4.1.2.j
• OS X 10.9.1
• Apple LLVM 5.0 compiler

[bartnijssen]

Suggested solution:

• Remove ARC_SOIL option from VIC (simply print error message that it is no longer supported)
• Reformat the PILPS 2e soil parameter files to the standard format
• Update the tar file with the PILPS test case, so it can still be used.

I'll find a volunteer to take this on.

[bartnijssen]

@jhamman : I am confused - should I issue the pull request against the master or against the develop branch?! I made the changes against the master (since this is basically a fix to prevent the memory error popping up that is documented here), but am not sure that is the correct work flow.

I cancelled the pull request, but can pretty easily re-issue it against either branch.

[jhamman]

I'd like to put this on the VIC.4.1.2.l hotfix branch. Can you move your pull request to point to that branch?

[bartnijssen]

Done