Coder Social home page Coder Social logo

Comments (6)

tbohn avatar tbohn commented on July 19, 2024

Another advantage of removing the explicit scheme would be a major simplification of the soil temperature code.

from vic.

tbohn avatar tbohn commented on July 19, 2024

Issue #66 would make the implicit scheme the default, without getting rid of the explicit scheme entirely. I'm suggesting issue #66 for VIC 4.2, with the idea that removing the explicit scheme entirely could happen at any later time.

I had forgotten about this issue when I opened issue #66, but the two issues potentially could be slated for different releases. Sorry if this is causing needless issue churn. Please feel free to rearrange/combine any of these issues as you see fit.

from vic.

tbohn avatar tbohn commented on July 19, 2024

I don't understand - you really want to remove the explicit scheme for 5.0? We still don't have a fix for frozen soil behavior; Tara Troy's code only works in the explicit mode. I really don't think we can do this for 5.0.

from vic.

bartnijssen avatar bartnijssen commented on July 19, 2024

@tbohn: Joe and are sitting/standing here laughing given your comment "I don't understand ..." in an issue that only has previous comments from you. Imagine how the rest of us feel :-)

from vic.

tbohn avatar tbohn commented on July 19, 2024

Sorry about any confusion. What exactly do you want to have happen? Just insert logic that exits with error if explicit is selected (easy) or remove all explicit-mode code from the model (harder)? I'm worried that this is a potential can of worms that we don't want to open before the release of 5.0.

from vic.

jhamman avatar jhamman commented on July 19, 2024

Agreed. We can move this to 5.1. This isn't related to the refactor and is best placed in 5.1.

from vic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.