Cumbersome input and output variable declarations in vicNl_def.h about vic

[jhamman]

@tbohn,

I think it would be easy enough to replace the current implementation with an enumeration like you mentioned. Eliminating the need to deal with the hard coded compile time integer tags. For example, we could set up a enumeration like this:

typedef enum OUTVARS
{
OUT_BASEFLOW,
OUT_DELINTERCEPT,
OUT_DELSOILMOIST,
OUT_DELSURFSTOR,
...
N_OUTVAR_TYPES
}

From there on, the implementation inside of VIC should be the same. N_OUTVAR_TYPES being the last value in the enumeration is the implicitly the number of the output variables.

One last point. With the addition of the netCDF output support in VIC.5, we will need to define metadata for each of these variables. At a bare minimum, we need to define these attributes:

• units,
• long name,
• description.

So, we should also be thinking about how best to store these too.

[jhamman]

closed via #175

[tbohn]

All these changes are great news!

On Fri, Dec 12, 2014 at 6:41 PM, Joe Hamman [email protected]
wrote:

Closed #36 #36.

—
Reply to this email directly or view it on GitHub
#36 (comment).