Coder Social home page Coder Social logo

Comments (3)

trel avatar trel commented on June 2, 2024

Is this due to davrods using open-write-close? rather than put?

from davrods.

cjsmeele avatar cjsmeele commented on June 2, 2024

Yes, it appears to be caused by the different API usage by davrods vs iput.
I haven't dived very deep into the underlying implementation of iput, but the rc function it uses to reach the specific "put" api (rcDataObjPut, vs Davrods rcDataObjOpen/Write/Close) appears to assume access to a local file by name. We cannot use this directly in Davrods, as we do not cache uploaded files - we are always dealing with streams.

It may be possible to reuse/change parts of rcDataObjPut to work without local filesystem access, but taking the complexity of the relevant library parts (rcPortalOpr.cpp) into account, I'm not sure that this belongs in Davrods.

A HTTP PUT is in my understanding still very much a "PUT" in iRODS, but as far as I currently understand, the client library no longer (re: oprType/static peps) has an ergonomic way to signal this without letting it perform on local files like icommands.
I'm interested to hear your thoughts on this.

FWIW: There used to be a similar issue with static PEPs not being triggered in pre-release versions of Davrods (irods/irods#3204 ) which was fixed by setting a oprType flag in the request. We still, currently, specify a "PUT" operation type to iRODS, but this has no apparent effect on dynamic PEPs.


For now, the API PEPs that are currently triggered by file PUTs through Davrods are:

pep_api_data_obj_create (only for new files)
pep_api_data_obj_open (only for existing files)
pep_api_data_obj_write
pep_api_data_obj_close

Corresponding resource PEPs are triggered as well, including pep_resource_modified at the end of the operation.

from davrods.

cjsmeele avatar cjsmeele commented on June 2, 2024

Per DICE-UNC/jargon#349 (comment), this is intentional behavior in iRODS and cannot be influenced by clients using open/write/close.
Using the iput-style put API would trigger the associated PEP, but as described above this is not an option for Davrods.

from davrods.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.