How to set up log recovery in Assise? about assise

[OmSaran]

I'm able to make the test pass now after making code changes

Here's what I did:

1. After this line, I added the following call: write_log_superblock((struct log_superblock *)g_log_sb);
2. After this line, I added the following call: shutdown_log();

It would be great if you can let me know if this is the correct way to do it, because adding write_log_superblock((struct log_superblock *)g_log_sb);, I believe would impact performance of all operations (wrapped in a transaction) in the filesystem.

[simpeter]

Waleed, Henry, does this seem correct to you? Is there perhaps some log recovery code missing in the public Assise repo?

…

On Wed, Nov 10, 2021 at 10:13 PM Om Saran ***@***.***> wrote: I'm able to make the test pass now: Here's what I did: 1. After this line <https://github.com/ut-osa/assise/blob/6f4aec82747d4d828c5c27b62b27c92b60fea79e/libfs/src/log/log.c#L1201>, I added the following call: write_log_superblock((struct log_superblock *)g_log_sb); 2. After this line <https://github.com/ut-osa/assise/blob/6f4aec82747d4d828c5c27b62b27c92b60fea79e/libfs/src/log/log.c#L146>, I added the following call: shutdown_log(); It would be great if you can let me know if this is the correct way to do it, because adding write_log_superblock((struct log_superblock *)g_log_sb);, I believe would impact performance. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABHQBMWN5CEDVFRSVJS3QPDULM7FFANCNFSM5HYVSHXA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[wreda]

Our artifact currently doesn't include a generalized implementation of log recovery. Your workaround should be okay for the test programs you shared. The added "write_log_superblock" call will affect write performance, as you said, but I don't expect it'll have a significant impact since the log superblock is only 40 bytes in size.

[OmSaran]

Thanks for the confirmation. I will try this out and see if it works for some other programs too.