Coder Social home page Coder Social logo

Comments (18)

stphnwlkr avatar stphnwlkr commented on May 18, 2024 1

Layout is much better ... thought I was in Chrome for a second. Actually the footer is now correct in both IE and Chrome.

from public-sans.

stphnwlkr avatar stphnwlkr commented on May 18, 2024 1

Looking good on the VA system

from public-sans.

stphnwlkr avatar stphnwlkr commented on May 18, 2024

We have seen this too, but only on some computers. I haven't been able to determine the cause, but it appears to be related to some policy that is pushed to those machines. One person sees it and the person next to them does not.

from public-sans.

thisisdano avatar thisisdano commented on May 18, 2024

I'll look into this — it's likely some kind of hinting error affected by Cleartype settings, but it may be hard to track down the right fix.

from public-sans.

fat32 avatar fat32 commented on May 18, 2024

I see this on two separate Windows setups:
Windows 10 at work,
Windows 7 at home (I don't remember that I did any ClearType tuning)

from public-sans.

thisisdano avatar thisisdano commented on May 18, 2024

I've been able to reproduce this, so hopefully I'll be able to find my way to a fix soon.

from public-sans.

thisisdano avatar thisisdano commented on May 18, 2024

@fat32 @stphnwlkr Can you look at the font rendering on this page and let me know if it shows the same mangled glyphs? Are there any other glyphs that have poor rendering?

https://federalist-proxy.app.cloud.gov/site/uswds/public-sans/

from public-sans.

stphnwlkr avatar stphnwlkr commented on May 18, 2024

I have only seen the issue as a result of others sharing the information. Interestingly, testing that site now...IE renders as Times New Roman inside the VA (flashed TNR externally before rendering), Chrome, Edge, and Firefox no issues.

from public-sans.

thisisdano avatar thisisdano commented on May 18, 2024

The site linked above does not include the eot version of the face, which I understand to be necessary only for IE6-9. But if the face isn't rendering for you @stphnwlkr (and I assume you're using something more current than IE9) then that's not good.

from public-sans.

stphnwlkr avatar stphnwlkr commented on May 18, 2024

I am using IE 11 and I verified it didn't get downgraded. When I look at the dev tools, it is not attempting to load the fonts ... must be a VA thing

from public-sans.

thisisdano avatar thisisdano commented on May 18, 2024

Hm, but it does load for... say v2.designsystem.digital.gov?

from public-sans.

thisisdano avatar thisisdano commented on May 18, 2024

This is the same specimen site, except with eot fronts in the @font-face rule:
https://federalist-proxy.app.cloud.gov/preview/uswds/public-sans/dw-test-eot/

@stphnwlkr Does it load for you?

from public-sans.

thisisdano avatar thisisdano commented on May 18, 2024

For reference, this is a screenshot of v2.designsystem.digital.gov from a Windows 10 / IE 11 instance via saucelabs. (The result is the same in Edge browsers.) Note the a characters that descend below the baseline:

Screen Shot 2019-03-21 at 1 46 01 PM

But I don't see similar output from the Public Sans specimen site — at least nothing as dramatic:
https://federalist-proxy.app.cloud.gov/preview/uswds/public-sans/dw-test-eot/

Screen Shot 2019-03-21 at 1 51 08 PM

I'd hope that a little sleuthing should get to a fix...

from public-sans.

stphnwlkr avatar stphnwlkr commented on May 18, 2024

VA system on Win 7 is not rendering anything - I think it is a VA configuration issue. The V2 site works although the layout is not quite right (header). My EHRM site (www.ehrm.va.gov) which is V2 beta 5 with Public Sans works fine.

from public-sans.

thisisdano avatar thisisdano commented on May 18, 2024

So the more recent version of Public Sans has this render error:
https://federalist-proxy.app.cloud.gov/preview/uswds/public-sans/18f-pages/

But the older version on the master branch does not:
https://federalist-proxy.app.cloud.gov/site/uswds/public-sans/

I ought to be able to work with that.

@stphnwlkr Header layout better here? https://federalist-proxy.app.cloud.gov/preview/uswds/uswds-site/dw-font-do-si-do/

from public-sans.

stphnwlkr avatar stphnwlkr commented on May 18, 2024

And yes, master is working fine.

from public-sans.

thisisdano avatar thisisdano commented on May 18, 2024

Updated fonts in action here: https://federalist-proxy.app.cloud.gov/preview/uswds/uswds-site/dw-font-do-si-do/

Screen Shot 2019-03-21 at 4 33 32 PM

Looks better in my testing. What do you see @fat32 and @stphnwlkr ?

from public-sans.

thisisdano avatar thisisdano commented on May 18, 2024

Fixed in #27

from public-sans.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.