Don’t expire jobs with working links about usrse.github.io

[vsoch]

@cosden I took a look and it's working as we expect - the goal of the script wasn't to immediately delete an expired job based on our date, but to delete an expired job with a link that is expired, because if you remember our CI was often failing because of broken links. So what the script does is loop through the current jobs, and regardless of expire or not, if the link is okay the file is kept. This is a more conservative approach to not immediately remove expired jobs because the creator might want to come back and change the date.

[vsoch]

You can look at the commit history and look for "Automated push to update jobs.yml" to see the times when it's found an expired link and removed it https://github.com/USRSE/usrse.github.io/commits/master. And you can look at the Actions tab to see that it is running.

[cosden]

Ah ok. Thanks @v! I was sure you'd know. I didn't look into it at all, I was just surprised to see so many old jobs still there. I agree that the way it's set up makes sense!

[cosden]

What do you think about keeping all jobs (regardless of supplied expiration date) if the link is active? Did we have the clean jobs script when we set up the expiration date?

Keeping with the more conservative approach, I think I'd rather err on the side of keeping up any possible open position even if the user supplied expiration date has passed.

[vsoch]

We can't keep jobs that have broken links because the url checker will fail, and we have to check the urls for the file so we can be sure we aren't serving broken links. So to be clear, currently we are conservative and try to keep all jobs, unless the url is 404, which isn't super useful to keep anyway (as the job has been removed).

[vsoch]

So you want to remove the expiration date check entirely? Just display whatever jobs are there?

[cosden]

So you want to remove the expiration date check entirely? Just display whatever jobs are there?

That's what I'm wondering. Removing broken links is important, but I'm trying to decide what purpose having a user supplied expiration date serves. If I just removed 4 jobs that "expired" in July but are still active postings, they could have been on the site for 3 months getting eyes on them. I'm trying to think of the downside. Jobs are filled but links never break? Does that happen? If so, maybe suggest a very distant expiration date, e.g. 9-12 months.

The jobs page is the most frequently viewed page (after the home page) on the site, so I think it's worth trying to get and keep as many jobs as possible there.

[vsoch]

Let’s try it! I’ll open a PR tomorrow.

[cosden]

Moving forward we'll set expiration dates far in advance. For now done in #308.