Coder Social home page Coder Social logo

Comments (8)

RiedleroD avatar RiedleroD commented on August 17, 2024 1

You forgot a tiny little detail: browser compatibility. Scroll down a bit & see that none of the variants work on more than 90% of all devices.

from userstyles.world.

Gusted avatar Gusted commented on August 17, 2024 1

See, 9953239 in it will be working in combination of the upcoming user settings.

from userstyles.world.

RiedleroD avatar RiedleroD commented on August 17, 2024

besides the fact that I'm very sceptical of handing the responsibility of styling elements down to the system.

from userstyles.world.

Gusted avatar Gusted commented on August 17, 2024

There is 2 things here, Quite frankly the one Riedler has pointed.

  1. I see you've mentioned that this is a native dark mode, it isn't. It's pure to style certain elements + the scrollbar.
  2. Don't trust the browsers. I've see chromium's dark mode development, I don't trust it to let chromium users see that mixed with our dark mode.
  3. It might be standardized for Safari/Chromium, but it still has some problems, see: whatwg/html#5426

^^ So that means that Chromium/Safari get's to see a mixed dark mode and we somehow have to resolve around the problem with other CSS engines to not be affected by this. I really love new inventions and that such things actually get standardized instead of just pushing it down to users/developers to adopt to, but it's at the moment not possible to have this implemented well holding compatibility.

from userstyles.world.

mxdanger avatar mxdanger commented on August 17, 2024

besides the fact that I'm very sceptical of handing the responsibility of styling elements down to the system.

We talked about this on the Discord, but I just want to let you know that this issue request is not anything you are suggesting. Using this option to let the browser know the website supports dark mode changes the default UA styling, it does not override any of the existing styling. As this website already has its own styling the only elements this change would affect, would be the native input elements like I mentioned such as checkboxes, dropdowns, and scrollbars.

The only potential compatibility issue is that users on old versions of Chromium would get white scrollbars instead of the website's custom scrollbar. Use GitHub for example, they already support this feature and it's a non-issue.

from userstyles.world.

mxdanger avatar mxdanger commented on August 17, 2024

You forgot a tiny little detail: browser compatibility. Scroll down a bit & see that none of the variants work on more than 90% of all devices.

This feature has 84% browser support. The other variants that you mentioned are deprecated, which you may have been unaware of.

from userstyles.world.

Gusted avatar Gusted commented on August 17, 2024

As this website already has its own styling the only elements this change would affect, would be the native input elements like I mentioned such as checkboxes, dropdowns, and scrollbars.

That's still the same problem I see, why partially let the system handle this and the other half let us style it with other non-color properties.

The only potential compatibility issue is that users on old versions of Chromium would get white scrollbars instead of the website's custom scrollbar.

It was rather a draft change, it seems like scrollbar wasn't originally covered in the css-color-adjust-1 and was still up to discussion so far I can see the history of the document with chromium source code. As it's still a draft and any comparability can change any time and chromium don't hassle to just remove the old behavior. I can implement it for now and see how things settle, but if causing me to write workarounds for workarounds the thing will get removed and Il let this draft get to a level-1 version before considering things again.

Regards,
Gusted

from userstyles.world.

vednoc avatar vednoc commented on August 17, 2024

@Gusted I'm going to reopen it and have it close automatically once changes are merged and live in production.

from userstyles.world.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.