Duplicate: Add a verification before import about userstyles.world

[decembre]

Checking only the name should not be enough:

If more users come to use the import function (and if batch import became available), i think some error can arrive:
Userstyles as a limitation for the userstyle's name and many userstyle for generic sites ( Google, YouTube...) and a same same type of change (Dark and Gray,..) can easily have a similar name, i suppose.

On greasyfork, i see many userscripts with the same name (and when i want remember them, i need add more infos if i bookmark them).
Not certain it should be a great deal, but if it possible to use another thing than title...

[Gusted]

We currently just check the style's name. I'm not sure if that is enough to prevent such issue as I don't know a clear example of this. https://github.com/userstyles-world/userstyles.world/blob/main/handlers/style/import.go#L84

[vednoc]

The warning will be "Duplicate style name". If it ends up being necessary, we could also check for equality in source code and/or other fields, but I think that having unique style names should be good enough.

Source: https://github.com/userstyles-world/userstyles.world/blob/653001fb38/models/style.go#L179

[vednoc]

can easily have a similar name, i suppose

That's why we check both the style name and the user ID. While I agree that it's not enough, it served us well thus far.

but if it possible to use another thing than title

By adding source code to the comparison, we will probably be good to go in 99.99% of the use-cases.

[Gusted]

By adding source code to the comparison, we will probably be good to go in 99.99% of the use-cases.

Wouldn't take take quite a performance hog?

[vednoc]

Wouldn't take take quite a performance hog?

Maybe. It's worth testing regardless of it being added or not.

[vednoc]

Added source code to comparison. If it ends up causing performance issues, we will revisit it.