Coder Social home page Coder Social logo

Comments (1)

UsernameFodder avatar UsernameFodder commented on August 30, 2024

This seems kind of counter to a core design goal of the repo and resymgen, which is to encourage "just add what you have" contributions. When most people do research, they're usually only looking at one version at a time. There's already plenty of symbols in the repo that are NA-only or EU-only.

I think it's better to have incomplete information than no information at all. If there were a requirement that contributions must be multi-version, it would be pretty stifling. If there are symbols we really care about that aren't addressed in all versions, people are welcome to make pull requests that add them, and having the symbols in other version even helps with that by enabling cross-referencing.

We could do nothing, but this would probably eventually lead to issues of the JP ROMs being barely supported by projects using pmdsky-debug.

IMO this isn't really in the scope of pmdsky-debug. This repo just provides all the information that's known. Verifying whether or not the JP offsets are present is a matter that ought to be up to users of the symbol tables.

A document describing contribution should be added (unless there is already one and I'm just blind)

There are already is one.

from pmdsky-debug.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.