Comments (6)
@davezen1 wondering how much of the cbp-header is customizable ? I was under the impression that no customization was allowed in terms of what its on it since that directly affected the goal of unified look & feel as users switched between applications. I understand that in the interim we have some freedom as to how each of the items on header are implemented. For example can we provide a default functionality of opening a dialog and "please contact such and such via some@email" or just mailto: some@email.
from ngx-cbp-theme.
Weather all the pieces are required or not would be good to know. I thought I had heard that things like preferences and feedback were 'optional', but maybe I misunderstood. Regardless, it might be better to still abstract those into there own components that contain the services; similar to how they are now. Then, you simply pull them in and drop them into the header. This would provide a nice separation of concerns. Currently, the header has some hard dependencies on the services for these. It might prove better to decouple those.
from ngx-cbp-theme.
Markup requirement for the end developer:-
<cbp-header>
<cbp-feedback-link></cbp-feedback-link>
</cbp-header>
Additionally refactor necessary templates from cbp-header.component.html
into appropriate components - mainly the feedback module.
from ngx-cbp-theme.
We have use case for external facing applications which do not have other parts. We will need to open up all other parts of CBP Headers as per @jscharett to be configurable instead of the current opinionated.
<cbp-header>
<cbp-apps-menu></cbp-apps-menu>
<cbp-feedback-link></cbp-feedback-link>
<cbp-user-menu></cbp-user-menu>
</cbp-header>
from ngx-cbp-theme.
+100 on the original comment (jscharett commented on Sep 7, 2017)
from ngx-cbp-theme.
PR #47 closes this.
from ngx-cbp-theme.
Related Issues (20)
- No longer works with Angular CLI HOT 2
- Upgrade & Lock versions
- Ability to subscribe to currentApp when the current app is detected HOT 1
- Upgrade to Angular and Material to latest RC version 5 HOT 1
- Toggle Switches component as per cbp-theme HOT 1
- Reuse .switch classes from cbp-theme
- Adding Applications Menu Link - link "See All Available Apps..." HOT 1
- Disabled Form Controls - Label to match with cbp-style-guide
- Toggle Buttons too light - seems like disabled
- page left & right padding HOT 1
- Handle SSO or User Already logged in HOT 2
- Develop CBP Theme Notifications
- material tabindex imported incorrectly causing build failures downstream
- CBPNotificationsService flat barrel broken HOT 1
- cbp-notifications not emitting isOpen() when closed
- cbp-header scrollshrink should only at 50 offset instead of any scrollups
- App Menu, User Menu remains open when CBP Header shrinks
- Make CBP Header click action configurable HOT 1
- CBP Notification isOpen should return true for default new notifications
- System Notification - Auto Close progress
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-cbp-theme.