Coder Social home page Coder Social logo

Simplify header about ngx-cbp-theme HOT 6 CLOSED

us-cbp avatar us-cbp commented on August 22, 2024 1
Simplify header

from ngx-cbp-theme.

Comments (6)

yogeshgadge avatar yogeshgadge commented on August 22, 2024

@davezen1 wondering how much of the cbp-header is customizable ? I was under the impression that no customization was allowed in terms of what its on it since that directly affected the goal of unified look & feel as users switched between applications. I understand that in the interim we have some freedom as to how each of the items on header are implemented. For example can we provide a default functionality of opening a dialog and "please contact such and such via some@email" or just mailto: some@email.

from ngx-cbp-theme.

jscharett avatar jscharett commented on August 22, 2024

Weather all the pieces are required or not would be good to know. I thought I had heard that things like preferences and feedback were 'optional', but maybe I misunderstood. Regardless, it might be better to still abstract those into there own components that contain the services; similar to how they are now. Then, you simply pull them in and drop them into the header. This would provide a nice separation of concerns. Currently, the header has some hard dependencies on the services for these. It might prove better to decouple those.

from ngx-cbp-theme.

yogeshgadge avatar yogeshgadge commented on August 22, 2024

Markup requirement for the end developer:-

<cbp-header>
    <cbp-feedback-link></cbp-feedback-link>
</cbp-header>

Additionally refactor necessary templates from cbp-header.component.html into appropriate components - mainly the feedback module.

from ngx-cbp-theme.

yogeshgadge avatar yogeshgadge commented on August 22, 2024

We have use case for external facing applications which do not have other parts. We will need to open up all other parts of CBP Headers as per @jscharett to be configurable instead of the current opinionated.

<cbp-header>
    <cbp-apps-menu></cbp-apps-menu>
    <cbp-feedback-link></cbp-feedback-link>
    <cbp-user-menu></cbp-user-menu>
</cbp-header>

from ngx-cbp-theme.

walhow avatar walhow commented on August 22, 2024

+100 on the original comment (jscharett commented on Sep 7, 2017)

from ngx-cbp-theme.

yogeshgadge avatar yogeshgadge commented on August 22, 2024

PR #47 closes this.

from ngx-cbp-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.