UseHandler(nil) behavior inconsistent with stdlib about negroni

[nathany]

Maybe even just a better error from UseHandler instead of panicking down the line?

[codegangsta]

@nathany this is a good point, I will leave this issue to remind me to update the documentation

[jszwedko]

I think maybe just panic()ing right away with a message indicating a nil handler is the best approach here. The alternative is to just exit the method early (skipping the pushing of a handler onto the stack), but I think that behavior is less expected by the user (e.g. they might think that they are passing in a non-nil handler that is being ignored).

[jszwedko]

To add a bit more context, I think negroni.Use is fundamentally different than http.ListenAndServe. The latter is a convenience function that is called to start a webserver (with the DefaultServerMux if no handler is specified), whereas negori.Uses sole purpose is to push a handler onto the stack -- i.e. you wouldn't call it if you weren't trying to push a handler onto the stack -- so pushing a nil should be unexpected.

[jszwedko]

Did not mean to close 😄

[nathany]

@jszwedko I agree, I think it just needs a better error message.

[nathany]

Thanks