Comments (2)
@rhugga Your sample code looks ok. I believe it should work. We've done some optimizations in urfave/cli since 2 years however all unit tests before those changes still pass. My guess is its the way the App.Run is called. Can you provide a complete sample with App initialization and when App.Run() is called ?
from cli.
@rhugga The following code based on your sample works as intended
package main
import (
"context"
"fmt"
"os"
"github.com/urfave/cli/v2"
)
// Options encapsulates run time options coming from the cli and env
type Options struct {
Host string
}
// Load is a cli before func used to inject cli options into the app context
func (o *Options) Load(app *cli.Context) error {
o.Host = app.String("host")
return nil
}
func Cmd(ctx context.Context) *cli.Command {
return &cli.Command{
Name: "mycommand",
Subcommands: []*cli.Command{
MyCmd(ctx),
},
}
}
func MyCmd(ctx context.Context) *cli.Command {
// here I instantiate my options struct
options := &Options{}
return &cli.Command{
Name: "foo",
Before: options.Load, // cli beforeFunc that loads cli options into my struct
Action: MyCmdAction(ctx, options), // pass options to action function
}
}
func MyCmdAction(ctx context.Context, o *Options) func(app *cli.Context) error {
return func(app *cli.Context) error {
fmt.Printf("OPTIONS=%+v\n", o) // nil here
return nil
}
}
func main() {
a := &cli.App{
Commands: []*cli.Command{
Cmd(context.TODO()),
},
Flags: []cli.Flag{
&cli.StringFlag{
Name: "host",
},
},
}
a.Run(os.Args)
}
$ go run main.go --host hello mycommand foo
OPTIONS=&{Host:hello}
I moved the flags to within the subcommand and that worked as well
$ go run main.go mycommand foo --host hello
OPTIONS=&{Host:hello}
So when you say it doesnt work is it possible you didnt specify the host flag on cmdline or maybe it was defined to pickup from the env ?
from cli.
Related Issues (20)
- Shell completion is suggesting aliases HOT 2
- How to use a custom CLI flag separator HOT 8
- Wrong help output when a Command has "HideHelpCommand=true" but no defined subcommands
- DefaultCommand does not work when defined on a sub-Command HOT 9
- subcommand help did show global options. HOT 1
- How do I define Usage for BoolWithInverseFlag? HOT 23
- Shell completions are broken when login shell is different than currently active shell
- Use mkdocs `mike` for multi-version docs
- Strictly limit default dependencies to stdlib HOT 6
- Build out all of the v3 documentation
- Vendor usage of `github.com/xrash/smetrics` for suggestions HOT 2
- Delete stale branches HOT 5
- Use gofumpt
- Man page generation feature is not documented anywhere HOT 3
- Doc generation default value set by environment variable HOT 4
- Expose shell completions scripts in by default in the `completion` command HOT 5
- More powerful shell completion HOT 2
- Ensure `go mod tidy` works as expected HOT 1
- Target `stable` and `oldstable` in main CI
- Flags are alphabetically sorted when using categories HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.