Comments (5)
+0 for leaving it. I'm of the view that CI is supposed to be the place where longer tests can run.
But I'm not going to push that. I'm not personally blocked by the tests, and I can approve PRs regardless of CI failures. It's nice that there's a MacOS build, but I wouldn't really care if there wasn't one.
from uportal-home.
I would vote to leave it as it is. It's valuable. Today Travis CI had some hardware issues. I can see the argument that having the checks increases productivity as well.
My second vote would be the allowing MacOS builds to fail. I'm open to other's thoughts.
from uportal-home.
+0 for leaving as-is. Differential failure on MacOS vs Linux shouldn't frequently be a thing, so the marginal value of including the MacOS build probably isn't high.
from uportal-home.
If its a non-blocker I am +1 for leaving as is.
If it becomes and issue I would support the allowed failure and fast finish option.
from uportal-home.
It sounds like there is consensus for leaving this as is for now.
This can be revisited if it becomes a blocker.
from uportal-home.
Related Issues (20)
- Enable layout reordering via keyboard HOT 2
- Meaningful page titles (WCAG2:2.4.2) HOT 1
- Implement pa11y for automated WCAG checking
- Implement Selective for a11y testing HOT 1
- An in-range update of jasmine-core is breaking the build 🚨 HOT 2
- An in-range update of lint-staged is breaking the build 🚨
- An in-range update of greenkeeper-lockfile is breaking the build 🚨 HOT 1
- An in-range update of jasmine-core is breaking the build 🚨 HOT 2
- An in-range update of eslint is breaking the build 🚨 HOT 2
- An in-range update of eslint-plugin-angular is breaking the build 🚨 HOT 2
- Alphabetical app directory sort isn't
- Optionally drop duplicate fnames from layout
- Idea: Give additional context on why a build failed HOT 2
- Failing WidgetController unit tests on master HOT 1
- update badges to reflect graduation from incubation
- NPM releases missing? HOT 1
- An in-range update of stylelint is breaking the build 🚨 HOT 5
- An in-range update of karma-jasmine-html-reporter is breaking the build 🚨 HOT 2
- An in-range update of eslint-plugin-markdown is breaking the build 🚨 HOT 1
- Migrate CI to Github Actions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uportal-home.