Coder Social home page Coder Social logo

Comments (5)

davidmsibley avatar davidmsibley commented on August 22, 2024 2

+0 for leaving it. I'm of the view that CI is supposed to be the place where longer tests can run.

But I'm not going to push that. I'm not personally blocked by the tests, and I can approve PRs regardless of CI failures. It's nice that there's a MacOS build, but I wouldn't really care if there wasn't one.

from uportal-home.

vertein avatar vertein commented on August 22, 2024 1

I would vote to leave it as it is. It's valuable. Today Travis CI had some hardware issues. I can see the argument that having the checks increases productivity as well.

My second vote would be the allowing MacOS builds to fail. I'm open to other's thoughts.

from uportal-home.

apetro avatar apetro commented on August 22, 2024 1

+0 for leaving as-is. Differential failure on MacOS vs Linux shouldn't frequently be a thing, so the marginal value of including the MacOS build probably isn't high.

from uportal-home.

ChristianMurphy avatar ChristianMurphy commented on August 22, 2024

If its a non-blocker I am +1 for leaving as is.
If it becomes and issue I would support the allowed failure and fast finish option.

from uportal-home.

ChristianMurphy avatar ChristianMurphy commented on August 22, 2024

It sounds like there is consensus for leaving this as is for now.
This can be revisited if it becomes a blocker.

from uportal-home.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.